From: Patrick Williams <patrick@stwcx.xyz>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: OpenBMC <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH] runqemu: Add palmetto target
Date: Thu, 17 Mar 2016 11:28:45 -0500 [thread overview]
Message-ID: <20160317162845.GB6045@asimov.austin.ibm.com> (raw)
In-Reply-To: <1458190368-24002-2-git-send-email-andrew@aj.id.au>
[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]
On Thu, Mar 17, 2016 at 03:22:48PM +1030, Andrew Jeffery wrote:
> diff --git a/yocto-poky/scripts/runqemu b/yocto-poky/scripts/runqemu
> index 23cf5be..f09da50 100755
> --- a/yocto-poky/scripts/runqemu
> +++ b/yocto-poky/scripts/runqemu
> @@ -110,7 +110,7 @@ while true; do
> arg=${1}
> case "$arg" in
> "qemux86" | "qemux86-64" | "qemuarm" | "qemuarm64" | "qemumips" | "qemumipsel" | \
> - "qemumips64" | "qemush4" | "qemuppc" | "qemumicroblaze" | "qemuzynq")
> + "qemumips64" | "qemush4" | "qemuppc" | "qemumicroblaze" | "qemuzynq" | "palmetto")
It seems like there should be a way to extend the machines in runqemu
without modifying the script. Maybe an environment variable like
"palmetto_SUPPORTS_QEMU=1" that we can set in one of the bitbake machine
files for each machine?
Might want to bounce this problem off of #yocto on IRC.
> +PALMETTO_DEFAULT_KERNEL=cuImage
> +PALMETTO_DEFAULT_FSTYPE=cpio.gz
Also ideally have these come from a bitbake file.
> + "palmetto")
> + mem_size=512
> + ;;
> +if [ "$MACHINE" = "palmetto" ]; then
> + QEMU=qemu-system-arm
> + MACHINE_SUBTYPE=palmetto-bmc
> + export QEMU_AUDIO_DRV="none"
> + KERNCMDLINE="console=ttyS4"
> + QEMUOPTIONS="$QEMU_NETWORK_CMD -M ${MACHINE_SUBTYPE} -initrd $ROOTFS -no-reboot -nographic"
> +fi
> +
Would be nice if this stuff was also in a bitbake file of sorts. Would
really be nice if we could leverage the machine classes (palmetto is-a
openpower) to reduce the redundancy.
>
> --
> 2.5.0
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
--
Patrick Williams
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-17 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 4:52 [RFC PATCH] Add palmetto target to runqemu Andrew Jeffery
2016-03-17 4:52 ` [PATCH] runqemu: Add palmetto target Andrew Jeffery
2016-03-17 5:19 ` Joel Stanley
2016-03-17 22:32 ` Andrew Jeffery
2016-03-17 7:42 ` Chris Austen
2016-03-17 16:33 ` Patrick Williams
2016-03-17 16:28 ` Patrick Williams [this message]
2016-03-17 22:59 ` Andrew Jeffery
[not found] ` <201603170742.u2H7gVIF013244@d03av03.boulder.ibm.com>
2016-03-17 22:38 ` Andrew Jeffery
2016-03-22 11:31 ` Andrew Jeffery
2016-03-17 15:53 ` [RFC PATCH] Add palmetto target to runqemu Patrick Williams
2016-03-17 22:40 ` Andrew Jeffery
2016-03-18 15:54 ` Patrick Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317162845.GB6045@asimov.austin.ibm.com \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.