All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: jasowang@redhat.com, jan.kiszka@siemens.com, thuth@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6
Date: Tue, 22 Mar 2016 00:55:11 +0100	[thread overview]
Message-ID: <20160321235511.GT4946@var.home> (raw)
In-Reply-To: <87h9g0ffof.fsf@blackfin.pond.sub.org>

Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote:
> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can
> > setup IPv4-only and IPv6-only network environments.
> 
> Do "net=" and "ip6-net=" mean anything useful?  If not, wouldn't that be
> a more natural way to switch off than abusing the wildcard address?

An empty parameter looks odd to me.  0.0.0.0 is used e.g. by ifconfig to
disable an interface, that's why I thought about it.  Perhaps an even
better way would be net=none and ip6-net=none?

> > @@ -2427,7 +2427,7 @@
> >  #
> >  # @ip: #optional legacy parameter, use net= instead
> >  #
> > -# @net: #optional IP address and optional netmask
> > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to disable IPv4 completely
> 
> Long line.
> 
> Syntax?  Default value?

Well, that's what was there :)

But yes I can add that along the way.  I'm however now wondering
what difference is supposed to exist between the documentation in
qapi-schema.json and in qemu-options.hx?  (I know they are separate
software layers, thus the two documentations, but does it make sense to
have differing documentations when the qapi schema and the CLI options
work the same?)

Samuel

  parent reply	other threads:[~2016-03-21 23:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-20 11:39 [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6 Samuel Thibault
2016-03-20 13:32 ` Samuel Thibault
2016-03-21  7:33 ` Thomas Huth
2016-03-21  7:33 ` Markus Armbruster
2016-03-21  9:02   ` Samuel Thibault
2016-03-21  9:44     ` Markus Armbruster
2016-03-21 23:55   ` Samuel Thibault [this message]
2016-03-22  7:41     ` Markus Armbruster
2016-03-22  8:02       ` Thomas Huth
2016-03-22 21:46   ` Samuel Thibault
2016-03-23 10:01     ` Markus Armbruster
2016-03-23 10:13 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321235511.GT4946@var.home \
    --to=samuel.thibault@gnu.org \
    --cc=armbru@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.