On Fri, Apr 15, 2016 at 10:17:36AM -0600, Sagar Dharia wrote:

Please leave blank lines between paragraphs, it makes things much easier
to read than a wall of uninterrupted text.

> >>+	ret = devm_request_irq(&pdev->dev, dev->irq, msm_slim_interrupt,
> >>+				IRQF_TRIGGER_HIGH, "msm_slim_irq", dev);
> >>+	if (ret) {
> >>+		dev_err(&pdev->dev, "request IRQ failed\n");
> >>+		goto err_request_irq_failed;
> >>+	}

> >Are you sure this is safe and we don't deallocate things the interrupt
> >handler uses before we disable the interrupt?

> Since clock is not enabled before this step, we won't be getting any
> interrupts from HW at this stage.

No, that's not what I'm saying - I'm asking about the *disable* path on
remove.