From: Jiri Olsa <jolsa@redhat.com>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>,
He Kuang <hekuang@huawei.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v5 3/6] perf record: Force enable --timestamp-filename when --switch-output is provided
Date: Wed, 20 Apr 2016 14:29:44 +0200 [thread overview]
Message-ID: <20160420122944.GC18012@krava.redhat.com> (raw)
In-Reply-To: <57173BFD.2040906@huawei.com>
On Wed, Apr 20, 2016 at 04:21:17PM +0800, Wangnan (F) wrote:
>
>
> On 2016/4/20 15:59, Jiri Olsa wrote:
> >On Mon, Apr 18, 2016 at 02:55:29PM +0000, Wang Nan wrote:
> >>Without this patch, the last output doesn't have timestamp appended if
> >>--timestamp-filename is not explicitly provided. For example:
> >>
> >> # perf record -a --switch-output &
> >> [1] 11224
> >> # kill -s SIGUSR2 11224
> >> [ perf record: dump data: Woken up 1 times ]
> >> # [ perf record: Dump perf.data.2015122622372823 ]
> >>
> >> # fg
> >> perf record -a --switch-output
> >> ^C[ perf record: Woken up 1 times to write data ]
> >> [ perf record: Captured and wrote 0.027 MB perf.data (540 samples) ]
> >>
> >> # ls -l
> >> total 836
> >> -rw------- 1 root root 33256 Dec 26 22:37 perf.data <---- *Odd*
> >> -rw------- 1 root root 817156 Dec 26 22:37 perf.data.2015122622372823
> >I'm getting this:
> >
> >[root@krava perf]# ./perf record -a --switch-output &
> >[root@krava perf]# kill -s SIGUSR2 18974
> >[ perf record: dump data: Woken up 4 times ]
> >[ perf record: Dump perf.data.2016042009574314 ]
> >
> >[root@krava perf]# ./perf report -i perf.data.2016042009574314
> >perf: Segmentation fault
> >-------- backtrace --------
> >./perf[0x552b0b]
> >/lib64/libc.so.6(+0x34a50)[0x7f711b434a50]
> >/lib64/libc.so.6(strlen+0x2a)[0x7f711b48b33a]
> >./perf(perf_hpp__reset_sort_width+0x4f)[0x4e9b1f]
> >./perf[0x54b113]
> >./perf(perf_evlist__tui_browse_hists+0x91)[0x551361]
> >./perf(cmd_report+0x1a34)[0x434b44]
> >./perf[0x485681]
> >./perf(main+0x672)[0x424382]
> >/lib64/libc.so.6(__libc_start_main+0xf0)[0x7f711b420700]
> >./perf(_start+0x29)[0x4244a9]
> >[0x0]
>
> Can't reproduce... Can you get reproduce problem without this patch (3/6)?
>
> My local tree is based on newest perf/core (commit ccd62a8 "perf trace:
> Fix build when DWARF unwind isn't available"). Could you please check your
> source?
you're right.. I rebuilt on latest Arnaldo's perf/core and can't reproduce again
jirka
next prev parent reply other threads:[~2016-04-20 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 14:55 [PATCH v5 0/6] perf tools: Use SIGUSR2 control data dumpping Wang Nan
2016-04-18 14:55 ` [PATCH v5 1/6] perf tools: Derive trigger class from auxtrace_snapshot Wang Nan
2016-04-20 7:46 ` Jiri Olsa
2016-04-20 13:20 ` Namhyung Kim
2016-04-18 14:55 ` [PATCH v5 2/6] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-04-20 7:54 ` Jiri Olsa
2016-04-18 14:55 ` [PATCH v5 3/6] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan
2016-04-20 7:59 ` Jiri Olsa
2016-04-20 8:21 ` Wangnan (F)
2016-04-20 12:29 ` Jiri Olsa [this message]
2016-04-18 14:55 ` [PATCH v5 4/6] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-04-18 14:55 ` [PATCH v5 5/6] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-04-18 14:55 ` [PATCH v5 6/6] perf record: Generate tracking events for process forked by perf Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420122944.GC18012@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.