From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:59238 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27026986AbcEELCjxbopd (ORCPT ); Thu, 5 May 2016 13:02:39 +0200 Date: Thu, 5 May 2016 12:02:30 +0100 From: Paul Burton Subject: Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host drivers Message-ID: <20160505110230.GA8303@NP-P-BURTON> References: <1454499045-5020-1-git-send-email-paul.burton@imgtec.com> <1454499045-5020-4-git-send-email-paul.burton@imgtec.com> <56FB0D90.8000200@gmail.com> <20160404100940.GA21568@NP-P-BURTON> <572AA3A0.5080201@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <572AA3A0.5080201@gmail.com> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Florian Fainelli Cc: linux-mips@linux-mips.org, Ralf Baechle , Joshua Kinard , Lorenzo Pieralisi , Bjorn Helgaas , Zubair Lutfullah Kakakhel , Jens Axboe , linux-kernel@vger.kernel.org, Yijing Wang , John Crispin , Yinghai Lu Message-ID: <20160505110230.hpO6gd5_s14Pjl-b-c032faekOm_Q5JNv_6cPCV0bCc@z> On Wed, May 04, 2016 at 06:36:32PM -0700, Florian Fainelli wrote: > Hi Paul, > > On 04/04/16 03:09, Paul Burton wrote: > > Hi Florian, > > > > Just an FYI, the pcie-xilinx driver I wrote this for has since been > > converted away from the ARM-like pci_common_init_dev & struct hw_pci to > > use only functions provided by the core PCI subsystem[1]. As a result > > I've stopped using this patch & don't plan to continue work on it. > > Perhaps it would be cleanest to do a similar conversion for the driver > > you're using? > > Yes, I did just that, but as of v4.6-rc6, I am seeing a bunch of > undefined references while doing so: > > arch/mips/pci/built-in.o: In function `pcibios_enable_device': > (.text+0x550): undefined reference to `pcibios_plat_dev_init' > arch/mips/pci/built-in.o: In function `pcibios_init': > pci.c:(.init.text+0x6c): undefined reference to `pcibios_map_irq' > pci.c:(.init.text+0x78): undefined reference to `pcibios_map_irq' > > and this makes perfect sense because arch/mips/pci/pci.c is referencing > those functions, while I did not add anything for BMIPS_GENERIC. > > At this point, I would very much prefer that the MIPS/Linux kernel did > not rely on the different machines to provide those implementations > (though it definitively is not a big deal to add them, it just feels > unnecessary), I will try to cook a patch for that and provide dummy > fallbacks. Hi Florian, I've done much the same for Boston already - do these patches work for you? https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=09f91e2742fa45ec6199e2657c4302ac432b7340 https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=7fa01b789d863eed17dd948266085c636d43786f https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=7b070e41a9f7fc2c8e0cfd94baf90134f27e89eb https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=c1f71dfc3de4ec018d2c4d8877e81da19e500211 https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=af3c4b3ed19d556489f67f7bb46f2dc83df7a617 https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=15229366d674bc4e846d5ef779f62f8bb730fe55 https://git.linux-mips.org/cgit/linux-mti.git/commit/?id=75b59b3bdddefda806e1b82b5b3aa60741df2e73 Or you could fetch & cherry-pick them from the linux-mti.git repository: git remote add mti git://git.linux-mips.org/pub/scm/linux-mti.git git fetch mti git cherry-pick 75b59b3bddde~7..75b59b3bddde They apply cleanly to v4.5, hopefully won't need much massaging to apply to current master. When I get to resubmitting the Boston board support these patches will be part of it. Thanks, Paul