All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: provide symlink dtc->linux-dtc is there is no dtc yet
Date: Tue, 31 May 2016 22:50:15 +0200	[thread overview]
Message-ID: <20160531225015.0f2039e5@free-electrons.com> (raw)
In-Reply-To: <1452252619-13802-1-git-send-email-patrickdepinguin@gmail.com>

Hello,

On Fri,  8 Jan 2016 12:30:19 +0100, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> Commit ab74e09eb4e28dab8bed8d783c5f0464d39a32e7 renamed the dtc host tool
> provided by linux to linux-dtc to avoid clashes with the dtc host tool
> provided by host-dtc.
> 
> However, external scripting may well rely on the existence of a device tree
> compiler as $(HOST_DIR)/usr/bin/dtc, regardless of its source. Changing
> these external scripts to use linux-dtc means that the scripts need to be
> aware of the buildroot release they are working with, which is not very
> nice.
> 
> Add a symlink dtc->linux-dtc when no $(HOST_DIR)/usr/bin/dtc is present.
> When host-dtc is not enabled, the end result will be dtc and
> linux-dtc representing the same thing.
> When host-dtc is enabled, either it is build before linux and no symlink
> is created at any time, or it is build after linux, and the 'install'
> command in host-dtc will overwrite the symlink with a proper dtc. In both
> cases, the end result will be dtc and linux-dtc representing a different
> thing.
> 
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

I've applied this patch to next, mainly because Arnout gave his
Reviewed-by, and because it has been waiting for a loooong time.

However, I don't quite get why you simply don't include host-dtc in
your build if you want to be sure to have something in
$(HOST_DIR)/usr/bin/dtc. We could even push the thing further and not
installed the Linux DTC at all in $(HOST_DIR) and simply ask people to
add host-dtc to their build if they need it.

But oh well, if we decide to move in this direction, it can be reworked
later, which is why I've applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-05-31 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 11:30 [Buildroot] [PATCH] linux: provide symlink dtc->linux-dtc is there is no dtc yet Thomas De Schampheleire
2016-01-09  0:52 ` Arnout Vandecappelle
2016-01-11  9:07   ` Thomas De Schampheleire
2016-05-31 20:50 ` Thomas Petazzoni [this message]
2016-06-01 14:41   ` Arnout Vandecappelle
2016-06-01 14:49     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531225015.0f2039e5@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.