From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-block@nongnu.org, pbonzini@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] linux-aio: Cancel BH if not needed
Date: Mon, 20 Jun 2016 11:34:02 +0100 [thread overview]
Message-ID: <20160620103402.GD3314@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160617102411.GD5431@noname.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]
On Fri, Jun 17, 2016 at 12:24:11PM +0200, Kevin Wolf wrote:
> Am 17.06.2016 um 12:13 hat Stefan Hajnoczi geschrieben:
> > On Wed, Jun 15, 2016 at 01:16:42PM +0200, Kevin Wolf wrote:
> > > linux-aio uses a BH in order to make sure that the remaining completions
> > > are processed even in nested event loops of completion callbacks in
> > > order to avoid deadlocks.
> > >
> > > There is no need, however, to have the BH overhead for the first call
> > > into qemu_laio_completion_bh() or after all pending completions have
> > > already been processed. Therefore, this patch calls directly into
> > > qemu_laio_completion_bh() in qemu_laio_completion_cb() and cancels
> > > the BH after qemu_laio_completion_bh() has processed all pending
> > > completions.
> > >
> > > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > > ---
> > > block/linux-aio.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > I ran 4 x iodepth=16 random 4KB read I/O benchmarks. There might be an
> > improvement but it's within the error margin. My benchmarking setup can
> > be noisy...
> >
> > Anyway, this patch doesn't hurt performance. Guest and host are RHEL 7.2.
>
> Thanks for confirming!
>
> > $ ./analyze.py runs/
> > Name IOPS Error
> > linux-aio-bh-optimizations-ccb9dc1 12942616.0 ± 16.83%
> > linux-aio-bh-optimizations-ccb9dc1-2 13833110.4 ± 4.74%
> > linux-aio-bh-optimizations-off-23b0d9f 13303981.4 ± 2.21%
>
> What are these three commits? Is the first one with your virtio-blk
> changes and this patch, the second only this patch and the third one
> the baseline?
The git trees are from qemu.git/master with no out-of-tree patches (my
stuff isn't there).
1. linux-aio-bh-optimizations-ccb9dc1 12942616.0 ± 16.83%
This is your "linux-aio: Cancel BH if not needed" in qemu.git/master.
2. linux-aio-bh-optimizations-ccb9dc1-2 13833110.4 ± 4.74%
I wanted to try again because the 16.83% error margin is very high and
probably due to noise. This is just a re-run of #1.
3. linux-aio-bh-optimizations-off-23b0d9f 13303981.4 ± 2.21%
This is the commit before your "linux-aio: Cancel BH if not needed"
(ccb9dc1^ == 23b0d9f).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-06-20 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 11:16 [Qemu-devel] [PATCH] linux-aio: Cancel BH if not needed Kevin Wolf
2016-06-15 12:39 ` Paolo Bonzini
2016-06-16 16:08 ` Stefan Hajnoczi
2016-06-17 10:13 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-17 10:24 ` Kevin Wolf
2016-06-20 10:34 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620103402.GD3314@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.