From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbcFXS1b (ORCPT ); Fri, 24 Jun 2016 14:27:31 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:47149 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbcFXS13 (ORCPT ); Fri, 24 Jun 2016 14:27:29 -0400 Date: Fri, 24 Jun 2016 12:27:27 -0600 From: Jason Gunthorpe To: Ed Swierk Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, jarkko.sakkinen@linux.intel.com, stefanb@us.ibm.com Subject: Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Message-ID: <20160624182727.GD14506@obsidianresearch.com> References: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-3-git-send-email-eswierk@skyportsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466557831-113440-3-git-send-email-eswierk@skyportsystems.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote: > if (chip->ops->req_canceled(chip, status)) { > dev_err(chip->pdev, "Operation Canceled\n"); > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > + ordinal, jiffies_to_msecs(jiffies - > start)); [..] > chip->ops->cancel(chip); > dev_err(chip->pdev, "Operation Timed out\n"); > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal, > + jiffies_to_msecs(jiffies - start)); No sense in logging twice, just enhance the existingerror message. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Date: Fri, 24 Jun 2016 12:27:27 -0600 Message-ID: <20160624182727.GD14506@obsidianresearch.com> References: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-3-git-send-email-eswierk@skyportsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1466557831-113440-3-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Ed Swierk Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote: > if (chip->ops->req_canceled(chip, status)) { > dev_err(chip->pdev, "Operation Canceled\n"); > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > + ordinal, jiffies_to_msecs(jiffies - > start)); [..] > chip->ops->cancel(chip); > dev_err(chip->pdev, "Operation Timed out\n"); > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal, > + jiffies_to_msecs(jiffies - start)); No sense in logging twice, just enhance the existingerror message. Jason ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape