From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbcFXUYL (ORCPT ); Fri, 24 Jun 2016 16:24:11 -0400 Received: from mga11.intel.com ([192.55.52.93]:54761 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbcFXUYJ (ORCPT ); Fri, 24 Jun 2016 16:24:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,522,1459839600"; d="scan'208";a="982796182" Date: Fri, 24 Jun 2016 23:24:03 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Ed Swierk , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, stefanb@us.ibm.com Subject: Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Message-ID: <20160624202403.GD8399@intel.com> References: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-3-git-send-email-eswierk@skyportsystems.com> <20160624182727.GD14506@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160624182727.GD14506@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2016 at 12:27:27PM -0600, Jason Gunthorpe wrote: > On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote: > > > if (chip->ops->req_canceled(chip, status)) { > > dev_err(chip->pdev, "Operation Canceled\n"); > > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > > + ordinal, jiffies_to_msecs(jiffies - > > start)); > > [..] > > > chip->ops->cancel(chip); > > dev_err(chip->pdev, "Operation Timed out\n"); > > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal, > > + jiffies_to_msecs(jiffies - start)); > > No sense in logging twice, just enhance the existingerror message. Absolutely agree. Jason, thanks for pointing this out! /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Date: Fri, 24 Jun 2016 23:24:03 +0300 Message-ID: <20160624202403.GD8399@intel.com> References: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-3-git-send-email-eswierk@skyportsystems.com> <20160624182727.GD14506@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160624182727.GD14506-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Jun 24, 2016 at 12:27:27PM -0600, Jason Gunthorpe wrote: > On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote: > > > if (chip->ops->req_canceled(chip, status)) { > > dev_err(chip->pdev, "Operation Canceled\n"); > > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > > + ordinal, jiffies_to_msecs(jiffies - > > start)); > > [..] > > > chip->ops->cancel(chip); > > dev_err(chip->pdev, "Operation Timed out\n"); > > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal, > > + jiffies_to_msecs(jiffies - start)); > > No sense in logging twice, just enhance the existingerror message. Absolutely agree. Jason, thanks for pointing this out! /Jarkko ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape