From: hch@infradead.org (Christoph Hellwig)
Subject: NVMe over Fabrics: NQN UUID byte order
Date: Tue, 28 Jun 2016 01:45:47 -0700 [thread overview]
Message-ID: <20160628084547.GA31465@infradead.org> (raw)
In-Reply-To: <1466792528.3234.9.camel@intel.com>
On Fri, Jun 24, 2016@06:22:11PM +0000, Verkamp, Daniel wrote:
> The NVMe 1.2.1 specification, section 7.9 (NVMe Qualified Names), says
> that the UUID format of NQN is based on RFC 4122, which explicitly
> requires all fields to be in big-endian/network byte order (section
> 4.1.2, Layout and Byte Order).
>
> However, the current NVMe over Fabrics host code generates and formats
> the Host Identifier UUID in little-endian byte order:
>
> >static struct nvmf_host *nvmf_host_default(void)
> >{
> [...]
> > uuid_le_gen(&host->id);
> > snprintf(host->nqn, NVMF_NQN_SIZE,
> > "nqn.2014-08.org.nvmexpress:NVMf:uuid:%pUl", &host-
> >id);
>
> Is this intentional or an oversight?
This isn't intentional. Can you send a patch to use uuid_be and
uuid_be_gen instead?
next prev parent reply other threads:[~2016-06-28 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 18:22 NVMe over Fabrics: NQN UUID byte order Verkamp, Daniel
2016-06-28 8:45 ` Christoph Hellwig [this message]
2016-06-28 18:20 ` [PATCH] nvme-fabrics: change NQN UUID to big-endian format Daniel Verkamp
2016-06-28 19:55 ` Freyensee, James P
2016-06-30 6:41 ` Christoph Hellwig
2016-08-18 19:48 ` Verkamp, Daniel
2016-08-19 9:02 ` Sagi Grimberg
2016-07-13 10:12 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628084547.GA31465@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.