From: Peter Chen <hzpeterchen@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY
Date: Thu, 18 Aug 2016 07:00:58 +0800 [thread overview]
Message-ID: <20160817230058.GA26420@shlinux2> (raw)
In-Reply-To: <87d1l77e0r.fsf@linux.intel.com>
On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:
>
> [...]
>
> > +static struct platform_driver wcove_typec_driver = {
> > + .driver = {
> > + .name = "bxt_wcove_usbc",
> > + },
> > + .probe = wcove_typec_probe,
> > + .remove = wcove_typec_remove,
> > +};
> > +
> > +module_platform_driver(wcove_typec_driver);
> > +
> > +MODULE_AUTHOR("Intel Corporation");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver");
>
> you need to add:
>
> MODULE_ALIAS("platform:bxt_wcove_usbc");
>
> otherwise this won't probe() automagically.
>
What do you mean, Felipe? If there is a platform device named
"bxt_wcove_usbc", why it will not be probed?
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-08-18 0:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 10:34 [PATCH v5 0/2] USB Type-C Connector class Heikki Krogerus
2016-08-17 10:34 ` [PATCH v5 1/2] usb: USB Type-C connector class Heikki Krogerus
2016-08-17 13:14 ` Frans Klaver
2016-08-17 13:53 ` Heikki Krogerus
2016-08-17 14:00 ` Frans Klaver
2016-08-17 13:30 ` Guenter Roeck
2016-08-17 13:56 ` Heikki Krogerus
2016-08-17 17:53 ` Guenter Roeck
2016-08-18 10:43 ` Heikki Krogerus
2016-08-17 17:58 ` Guenter Roeck
2016-08-18 10:44 ` Heikki Krogerus
2016-08-17 10:34 ` [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-08-17 12:53 ` Felipe Balbi
2016-08-17 13:32 ` Heikki Krogerus
2016-08-17 23:00 ` Peter Chen [this message]
2016-08-18 6:33 ` Felipe Balbi
2016-08-18 13:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817230058.GA26420@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.