Re: [PATCH] xfs: kill __uint*_t and __int*_t

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Wed, Aug 24, 2016 at 08:35:00AM +1000, Dave Chinner wrote:
> On Tue, Aug 09, 2016 at 01:33:32AM -0700, Christoph Hellwig wrote:
> > On Sun, Aug 07, 2016 at 07:38:35PM +0200, Felix Janda wrote:
> > > Replace them by the more widely used uint*_t and int*_t.
> > > 
> > > Signed-off-by: Felix Janda <felix.janda@posteo.de>
> > > ---
> > > This patch is essentially a global
> > > 'sed -i "s/__\(u*\)int\([0-9]*\)_t/\1int\2_t/"'. The only other changes
> > > are whitespace changes and removing the now unecessary type definitions.
> > > 
> > > Running 'sed "s/^.//"' on the patch might be useful for checking that
> > > I didn't mess up the indentation.
> > 
> > If everyone is fine using (u)int*_t over s*/u* this looks good.  I'd
> > have a slight preference for s*/u* as in the rest of the kernel, but
> > either way getting rid of our crazy __ types is a good thing.
> 
> Don't really care that much. I'd prefer (marginally) to go with the
> (u)int*_t types as userspace then doesn't need a set of typedefs in
> the platform headers to support the kernel specific types in libxfs
> code....

I don't mind moving from __uintXX_t to uintXX_t so long as the changes
land in the kernel and xfsprogs at the same time.

Basically, I use stgit with my kernel/xfsprogs git repos to maintain the
stack of patches that go to the mailing lists.  Right now the libxfs
code in both are nearly identical, so it's very easy to jump to the
middle of the stack, make a change, and send it to the other git repo.
This becomes much more painful if I have to edit a diff as it jumps
between repos so that they apply and build.

--D

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs