From: Peter Xu <peterx@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com,
vkaplans@redhat.com, alex.williamson@redhat.com, wexu@redhat.com,
pbonzini@redhat.com, cornelia.huck@de.ibm.com,
dgibson@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed
Date: Wed, 14 Sep 2016 19:25:32 +0800 [thread overview]
Message-ID: <20160914112532.GA3652@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160914103734.GQ15077@voom.fritz.box>
On Wed, Sep 14, 2016 at 08:37:34PM +1000, David Gibson wrote:
[...]
> > This should not be related to the interface at all?
> >
> > I was based on the assumption that "Power cannot support either one of
> > MAP/UNMAP, but only if both exist".
>
> Huh? I have no idea what you mean by that.
>
> Power can support notifying both map and unmap events just fine - but
> in order to provide *any* notifications, it has to disable KVM
> acceleration of the guest-side IOMMU (otherwise qemu won't know about
> any changes to the IOMMU state).
>
> So the change you you suggested before to != IOMMU_NOTIFIER_NONE is
> exactly correct, anything else is not.
Sorry I was wrong. Yes user can register with only one (MAP or UNMAP)
notifier type for any platform.
Thanks.
-- peterx
next prev parent reply other threads:[~2016-09-14 11:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 2:57 [Qemu-devel] [PATCH v4 0/3] Introduce IOMMUNotifier struct Peter Xu
2016-09-09 2:57 ` [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps Peter Xu
2016-09-14 5:48 ` David Gibson
2016-09-14 7:15 ` David Gibson
2016-09-14 7:40 ` Peter Xu
2016-09-14 10:47 ` David Gibson
2016-09-14 8:17 ` Peter Xu
2016-09-14 10:50 ` David Gibson
2016-09-09 2:57 ` [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed Peter Xu
2016-09-14 5:55 ` David Gibson
2016-09-14 7:12 ` Peter Xu
2016-09-14 7:22 ` David Gibson
2016-09-14 7:49 ` Peter Xu
2016-09-14 10:37 ` David Gibson
2016-09-14 11:25 ` Peter Xu [this message]
2016-09-09 2:57 ` [Qemu-devel] [PATCH v4 3/3] intel_iommu: allow UNMAP notifiers Peter Xu
2016-09-14 5:56 ` David Gibson
2016-09-09 4:05 ` [Qemu-devel] [PATCH v4 0/3] Introduce IOMMUNotifier struct no-reply
2016-09-09 6:41 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914112532.GA3652@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vkaplans@redhat.com \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.