From: no-reply@patchew.org
To: hpoussin@reactos.org
Cc: famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements
Date: Wed, 14 Sep 2016 16:01:30 -0700 (PDT) [thread overview]
Message-ID: <20160914230125.19908.40993@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <1473890265-3304-1-git-send-email-hpoussin@reactos.org>
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1473890265-3304-1-git-send-email-hpoussin@reactos.org
Subject: [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f897257 ps2: do not generate invalid key codes for unknown keys
8a471af ps2: use QEMU qcodes instead of scancodes
af3f9d4 ps2: allow keycode translation for all scancode sets
0efd0b0 ps2: correctly handle 'get/set scancode' command
dcc6e28 ps2: reject unknown commands, instead of blindly accepting them
=== OUTPUT BEGIN ===
Checking PATCH 1/5: ps2: reject unknown commands, instead of blindly accepting them...
Checking PATCH 2/5: ps2: correctly handle 'get/set scancode' command...
Checking PATCH 3/5: ps2: allow keycode translation for all scancode sets...
ERROR: line over 90 characters
#45: FILE: hw/input/ps2.c:140:
+ 0xff, 0x43, 0x41, 0x3f, 0x3d, 0x3b, 0x3c, 0x58, 0x64, 0x44, 0x42, 0x40, 0x3e, 0x0f, 0x29, 0x59,
ERROR: line over 90 characters
#46: FILE: hw/input/ps2.c:141:
+ 0x65, 0x38, 0x2a, 0x70, 0x1d, 0x10, 0x02, 0x5a, 0x66, 0x71, 0x2c, 0x1f, 0x1e, 0x11, 0x03, 0x5b,
ERROR: line over 90 characters
#47: FILE: hw/input/ps2.c:142:
+ 0x67, 0x2e, 0x2d, 0x20, 0x12, 0x05, 0x04, 0x5c, 0x68, 0x39, 0x2f, 0x21, 0x14, 0x13, 0x06, 0x5d,
ERROR: line over 90 characters
#48: FILE: hw/input/ps2.c:143:
+ 0x69, 0x31, 0x30, 0x23, 0x22, 0x15, 0x07, 0x5e, 0x6a, 0x72, 0x32, 0x24, 0x16, 0x08, 0x09, 0x5f,
ERROR: line over 90 characters
#49: FILE: hw/input/ps2.c:144:
+ 0x6b, 0x33, 0x25, 0x17, 0x18, 0x0b, 0x0a, 0x60, 0x6c, 0x34, 0x35, 0x26, 0x27, 0x19, 0x0c, 0x61,
ERROR: line over 90 characters
#50: FILE: hw/input/ps2.c:145:
+ 0x6d, 0x73, 0x28, 0x74, 0x1a, 0x0d, 0x62, 0x6e, 0x3a, 0x36, 0x1c, 0x1b, 0x75, 0x2b, 0x63, 0x76,
ERROR: line over 90 characters
#51: FILE: hw/input/ps2.c:146:
+ 0x55, 0x56, 0x77, 0x78, 0x79, 0x7a, 0x0e, 0x7b, 0x7c, 0x4f, 0x7d, 0x4b, 0x47, 0x7e, 0x7f, 0x6f,
ERROR: line over 90 characters
#52: FILE: hw/input/ps2.c:147:
+ 0x52, 0x53, 0x50, 0x4c, 0x4d, 0x48, 0x01, 0x45, 0x57, 0x4e, 0x51, 0x4a, 0x37, 0x49, 0x46, 0x54,
ERROR: line over 90 characters
#53: FILE: hw/input/ps2.c:148:
+ 0x80, 0x81, 0x82, 0x41, 0x54, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8c, 0x8d, 0x8e, 0x8f,
ERROR: line over 90 characters
#54: FILE: hw/input/ps2.c:149:
+ 0x90, 0x91, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98, 0x99, 0x9a, 0x9b, 0x9c, 0x9d, 0x9e, 0x9f,
ERROR: line over 90 characters
#55: FILE: hw/input/ps2.c:150:
+ 0xa0, 0xa1, 0xa2, 0xa3, 0xa4, 0xa5, 0xa6, 0xa7, 0xa8, 0xa9, 0xaa, 0xab, 0xac, 0xad, 0xae, 0xaf,
ERROR: line over 90 characters
#56: FILE: hw/input/ps2.c:151:
+ 0xb0, 0xb1, 0xb2, 0xb3, 0xb4, 0xb5, 0xb6, 0xb7, 0xb8, 0xb9, 0xba, 0xbb, 0xbc, 0xbd, 0xbe, 0xbf,
ERROR: line over 90 characters
#57: FILE: hw/input/ps2.c:152:
+ 0xc0, 0xc1, 0xc2, 0xc3, 0xc4, 0xc5, 0xc6, 0xc7, 0xc8, 0xc9, 0xca, 0xcb, 0xcc, 0xcd, 0xce, 0xcf,
ERROR: line over 90 characters
#58: FILE: hw/input/ps2.c:153:
+ 0xd0, 0xd1, 0xd2, 0xd3, 0xd4, 0xd5, 0xd6, 0xd7, 0xd8, 0xd9, 0xda, 0xdb, 0xdc, 0xdd, 0xde, 0xdf,
ERROR: line over 90 characters
#59: FILE: hw/input/ps2.c:154:
+ 0xe0, 0xe1, 0xe2, 0xe3, 0xe4, 0xe5, 0xe6, 0xe7, 0xe8, 0xe9, 0xea, 0xeb, 0xec, 0xed, 0xee, 0xef,
ERROR: line over 90 characters
#60: FILE: hw/input/ps2.c:155:
+ 0xf0, 0xf1, 0xf2, 0xf3, 0xf4, 0xf5, 0xf6, 0xf7, 0xf8, 0xf9, 0xfa, 0xfb, 0xfc, 0xfd, 0xfe, 0xff,
total: 16 errors, 0 warnings, 165 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/5: ps2: use QEMU qcodes instead of scancodes...
ERROR: if this code is redundant consider removing it
#163: FILE: hw/input/ps2.c:226:
+#if 0
ERROR: if this code is redundant consider removing it
#311: FILE: hw/input/ps2.c:365:
+#if 0
total: 2 errors, 0 warnings, 554 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/5: ps2: do not generate invalid key codes for unknown keys...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
next prev parent reply other threads:[~2016-09-15 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 21:57 [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 1/5] ps2: reject unknown commands, instead of blindly accepting them Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 2/5] ps2: correctly handle 'get/set scancode' command Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 3/5] ps2: allow keycode translation for all scancode sets Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 4/5] ps2: use QEMU qcodes instead of scancodes Hervé Poussineau
2016-09-14 21:57 ` [Qemu-devel] [PATCH 5/5] ps2: do not generate invalid key codes for unknown keys Hervé Poussineau
2016-09-14 22:40 ` [Qemu-devel] [PATCH 0/5] ps2: fix keyboard set 3 and misc improvements no-reply
2016-09-14 23:01 ` no-reply [this message]
2016-09-15 7:40 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914230125.19908.40993@ex-std-node742.prod.rhcloud.com \
--to=no-reply@patchew.org \
--cc=famz@redhat.com \
--cc=hpoussin@reactos.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.