From: kbuild test robot <lkp@intel.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: kbuild-all@01.org, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
Van Jacobson <vanj@google.com>,
Neal Cardwell <ncardwell@google.com>,
Nandita Dukkipati <nanditad@google.com>,
Eric Dumazet <edumazet@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH net-next 07/14] tcp: export data delivery rate
Date: Sat, 17 Sep 2016 11:56:59 +0800 [thread overview]
Message-ID: <201609171104.7NaqQo41%fengguang.wu@intel.com> (raw)
In-Reply-To: <1474051743-13311-8-git-send-email-ncardwell@google.com>
[-- Attachment #1: Type: text/plain, Size: 4180 bytes --]
Hi Yuchung,
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323
config: arm-nhk8815_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All error/warnings (new ones prefixed by >>):
In file included from arch/arm/include/asm/div64.h:126:0,
from include/linux/kernel.h:142,
from include/linux/crypto.h:21,
from include/crypto/hash.h:16,
from net/ipv4/tcp.c:250:
net/ipv4/tcp.c: In function 'tcp_get_info':
include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast
(void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
^
>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div'
do_div(rate, intv);
^~~~~~
In file included from arch/arm/include/asm/atomic.h:14:0,
from include/linux/atomic.h:4,
from include/linux/crypto.h:20,
from include/crypto/hash.h:16,
from net/ipv4/tcp.c:250:
include/asm-generic/div64.h:220:25: warning: right shift count >= width of type [-Wshift-count-overflow]
} else if (likely(((n) >> 32) == 0)) { \
^
include/linux/compiler.h:167:40: note: in definition of macro 'likely'
# define likely(x) __builtin_expect(!!(x), 1)
^
>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div'
do_div(rate, intv);
^~~~~~
In file included from arch/arm/include/asm/div64.h:126:0,
from include/linux/kernel.h:142,
from include/linux/crypto.h:21,
from include/crypto/hash.h:16,
from net/ipv4/tcp.c:250:
>> include/asm-generic/div64.h:224:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
__rem = __div64_32(&(n), __base); \
^
>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div'
do_div(rate, intv);
^~~~~~
In file included from include/linux/kernel.h:142:0,
from include/linux/crypto.h:21,
from include/crypto/hash.h:16,
from net/ipv4/tcp.c:250:
arch/arm/include/asm/div64.h:32:24: note: expected 'uint64_t * {aka long long unsigned int *}' but argument is of type 'u32 * {aka unsigned int *}'
static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/do_div +2794 net/ipv4/tcp.c
2778 } while (u64_stats_fetch_retry_irq(&tp->syncp, start));
2779 info->tcpi_segs_out = tp->segs_out;
2780 info->tcpi_segs_in = tp->segs_in;
2781
2782 notsent_bytes = READ_ONCE(tp->write_seq) - READ_ONCE(tp->snd_nxt);
2783 info->tcpi_notsent_bytes = max(0, notsent_bytes);
2784
2785 info->tcpi_min_rtt = tcp_min_rtt(tp);
2786 info->tcpi_data_segs_in = tp->data_segs_in;
2787 info->tcpi_data_segs_out = tp->data_segs_out;
2788
2789 info->tcpi_delivery_rate_app_limited = tp->rate_app_limited ? 1 : 0;
2790 rate = READ_ONCE(tp->rate_delivered);
2791 intv = READ_ONCE(tp->rate_interval_us);
2792 if (rate && intv) {
2793 rate = rate * tp->mss_cache * USEC_PER_SEC;
> 2794 do_div(rate, intv);
2795 put_unaligned(rate, &info->tcpi_delivery_rate);
2796 }
2797 }
2798 EXPORT_SYMBOL_GPL(tcp_get_info);
2799
2800 static int do_tcp_getsockopt(struct sock *sk, int level,
2801 int optname, char __user *optval, int __user *optlen)
2802 {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 14948 bytes --]
next prev parent reply other threads:[~2016-09-16 19:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 18:48 [PATCH net-next 00/14] tcp: BBR congestion control algorithm Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 01/14] lib/win_minmax: windowed min or max estimator Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 02/14] tcp: use windowed min filter library for TCP min_rtt estimation Neal Cardwell
2016-09-16 19:21 ` kbuild test robot
2016-09-16 19:25 ` Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 03/14] net_sched: sch_fq: add low_rate_threshold parameter Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 04/14] tcp: count packets marked lost for a TCP connection Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 05/14] tcp: track data delivery rate " Neal Cardwell
2016-09-16 21:38 ` kbuild test robot
2016-09-17 12:09 ` Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 06/14] tcp: track application-limited rate samples Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 07/14] tcp: export data delivery rate Neal Cardwell
2016-09-16 21:38 ` kbuild test robot
2016-09-17 3:56 ` kbuild test robot [this message]
2016-09-16 20:03 ` Neal Cardwell
2016-09-16 20:11 ` Eric Dumazet
2016-09-16 20:04 ` Eric Dumazet
2016-09-16 18:48 ` [PATCH net-next 08/14] tcp: allow congestion control module to request TSO skb segment count Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 09/14] tcp: export tcp_tso_autosize() and parameterize minimum number of TSO segments Neal Cardwell
2016-09-16 18:48 ` [PATCH net-next 10/14] tcp: export tcp_mss_to_mtu() for congestion control modules Neal Cardwell
2016-09-16 18:49 ` [PATCH net-next 11/14] tcp: allow congestion control to expand send buffer differently Neal Cardwell
2016-09-16 18:49 ` [PATCH net-next 12/14] tcp: new CC hook to set sending rate with rate_sample in any CA state Neal Cardwell
2016-09-16 18:49 ` [PATCH net-next 13/14] tcp: increase ICSK_CA_PRIV_SIZE from 64 bytes to 88 Neal Cardwell
2016-09-16 18:49 ` [PATCH net-next 14/14] tcp_bbr: add BBR congestion control Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609171104.7NaqQo41%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kbuild-all@01.org \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=vanj@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.