From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
Date: Thu, 22 Sep 2016 09:53:09 -0000 [thread overview]
Message-ID: <20160922095309.27899.16033.malone@chaenomeles.canonical.com> (raw)
In-Reply-To: 20160921082958.18035.57524.malonedeb@wampee.canonical.com
This is clearly a bug, but your suggested change won't deal with the
problem, which is that we're trying to set a bool so the ? 32 : 64
construct is just wrong.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1625987
Title:
target-arm/translate-a64.c:2028: possible coding error ?
Status in QEMU:
New
Bug description:
target-arm/translate-a64.c:2028:37: warning: ?: using integer
constants in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
next prev parent reply other threads:[~2016-09-22 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 8:29 [Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ? dcb
2016-09-22 9:53 ` Peter Maydell [this message]
2016-09-30 1:40 ` [Qemu-devel] [Bug 1625987] " Peter Maydell
2016-09-30 10:21 ` Edgar E. Iglesias
2016-10-04 13:36 ` Peter Maydell
2017-01-16 11:45 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922095309.27899.16033.malone@chaenomeles.canonical.com \
--to=peter.maydell@linaro.org \
--cc=1625987@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.