From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757976AbcK3VHv (ORCPT ); Wed, 30 Nov 2016 16:07:51 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:55428 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754122AbcK3VHX (ORCPT ); Wed, 30 Nov 2016 16:07:23 -0500 Message-Id: <20161130210030.509567906@linutronix.de> User-Agent: quilt/0.63-1 Date: Wed, 30 Nov 2016 21:04:44 -0000 From: Thomas Gleixner To: LKML Cc: David Daney , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Sebastian Siewior , Will Deacon , Mark Rutland Subject: [patch 3/4] rtmutex: Get rid of RT_MUTEX_OWNER_MASKALL References: <20161130205431.629977871@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Disposition: inline; filename=rtmutex--Get-rid-of-RT_MUTEX_OWNER_MASKALL.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a left over from the original rtmutex implementation which used both bit0 and bit1 in the owner pointer. Commit 8161239a8bcc ("rtmutex: Simplify PI algorithm and make highest prio task get lock") removed the usage of bit1, but kept the extra mask around. This is confusing at best. Remove it and just use RT_MUTEX_HAS_WAITERS for the masking. Signed-off-by: Thomas Gleixner --- kernel/locking/rtmutex_common.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/locking/rtmutex_common.h +++ b/kernel/locking/rtmutex_common.h @@ -71,13 +71,12 @@ task_top_pi_waiter(struct task_struct *p * lock->owner state tracking: */ #define RT_MUTEX_HAS_WAITERS 1UL -#define RT_MUTEX_OWNER_MASKALL 1UL static inline struct task_struct *rt_mutex_owner(struct rt_mutex *lock) { unsigned long owner = (unsigned long) READ_ONCE(lock->owner); - return (struct task_struct *) (owner & ~RT_MUTEX_OWNER_MASKALL); + return (struct task_struct *) (owner & ~RT_MUTEX_HAS_WAITERS); } /*