From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>,
JulienGrall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 1/2] x86/paging: Update paging_mark_dirty() to use mfn_t
Date: Wed, 14 Dec 2016 10:48:21 -0500 [thread overview]
Message-ID: <20161214154821.GD6977@char.us.oracle.com> (raw)
In-Reply-To: <fb637b55-b6ec-7b99-bef0-31c2211391ce@citrix.com>
On Wed, Dec 14, 2016 at 03:28:49PM +0000, Andrew Cooper wrote:
> On 14/12/16 15:13, Jan Beulich wrote:
> >>>> On 14.12.16 at 15:26, <andrew.cooper3@citrix.com> wrote:
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> ---
> >> CC: Jan Beulich <JBeulich@suse.com>
> >> CC: Tim Deegan <tim@xen.org>
> >> CC: George Dunlap <george.dunlap@eu.citrix.com>
> >> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >> CC: Stefano Stabellini <sstabellini@kernel.org>
> >> CC: Julien Grall <julien.grall@arm.com>
> >>
> >> The one use of paging_mark_dirty() in common/tmem shows that TMEM currently
> >> wont compile for ARM.
> > I don't understand: It builds prior to this change, so why would it
> > stop building afterwards? Without this remark I'd have given my
> > R-b ...
>
> Oh. cli_{get,put}_page() are stubbed to ASSERT(0) on ARM, which
> restricts the paging_mark_dirty() call to !ARM.
>
> The history is weird here. The last change here was you taking out the
> __ia64__ code.
>
> I can't work out why they should be stubbed separately; there is nothing
> overly x86-specific in them.
>
> Konrad: Any ideas?
My recollection was that nobody had tried tmem under ARM and it made
it just easier to bypass it until the security audit is completed.
But ARM is the perfect candidate for tmem.. I did have enabling tmem
on ARM on my TODO list but it is below migration. Hm.
I am with changes that look "OKish" to the tmem and then fixing
them when I get my hands on enabling tmem on ARM.
>
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-14 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 14:26 [PATCH 1/2] x86/paging: Update paging_mark_dirty() to use mfn_t Andrew Cooper
2016-12-14 14:26 ` [PATCH 2/2] x86/paging: Rename paging_mark_pfn_dirty() and use pfn_t Andrew Cooper
2016-12-14 15:22 ` Jan Beulich
2016-12-14 15:30 ` Andrew Cooper
2016-12-20 5:08 ` Tian, Kevin
2016-12-14 15:13 ` [PATCH 1/2] x86/paging: Update paging_mark_dirty() to use mfn_t Jan Beulich
2016-12-14 15:28 ` Andrew Cooper
2016-12-14 15:48 ` Konrad Rzeszutek Wilk [this message]
2016-12-14 15:36 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214154821.GD6977@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.