Re: [PATCH] Avoid that reloading a map sporadically triggers I/O errors

From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] Avoid that reloading a map sporadically triggers I/O errors
Date: Wed, 4 Jan 2017 13:56:43 -0600	[thread overview]
Message-ID: <20170104195643.GK2732@octiron.msp.redhat.com> (raw)
In-Reply-To: <d044817b-ea55-f42f-3895-5c539260ed80@sandisk.com>

On Wed, Dec 07, 2016 at 03:37:44PM -0800, Bart Van Assche wrote:

ACK

-Ben

> Christophe and Hannes, do you want to comment on this patch?
> 
> Thanks,
> 
> Bart.
> 
> On 11/18/2016 01:33 PM, Bart Van Assche wrote:
> >Avoid that reloading a map while there are no paths triggers a flush
> >and hence unwanted I/O errors if 'queue_if_no_path' is enabled.
> >
> >Fixes: commit d569988e7528 ("libmultipath: Fixup 'DM_DEVICE_RELOAD' handling")
> >Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> >Cc: Hannes Reinecke <hare@suse.de>
> >---
> > libmultipath/devmapper.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
> >index f92ebce..31f1962 100644
> >--- a/libmultipath/devmapper.c
> >+++ b/libmultipath/devmapper.c
> >@@ -390,7 +390,7 @@ int dm_addmap_reload(struct multipath *mpp, char *params, int flush)
> > 			      params, ADDMAP_RO, SKIP_KPARTX_OFF);
> > 	}
> > 	if (r)
> >-		r = dm_simplecmd(DM_DEVICE_RESUME, mpp->alias, flush,
> >+		r = dm_simplecmd(DM_DEVICE_RESUME, mpp->alias, !flush,
> > 				 1, udev_flags, 0);
> > 	return r;
> > }
> >
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel