From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbdBORzK (ORCPT ); Wed, 15 Feb 2017 12:55:10 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:32860 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbdBORzI (ORCPT ); Wed, 15 Feb 2017 12:55:08 -0500 Date: Wed, 15 Feb 2017 09:55:05 -0800 From: Moritz Fischer To: Alan Tull Cc: Jason Gunthorpe , linux-kernel , linux-fpga@vger.kernel.org Subject: Re: [RFC 7/8] fpga-region: add sysfs interface Message-ID: <20170215175505.GA30186@live.com> References: <1487175261-7051-1-git-send-email-atull@kernel.org> <1487175261-7051-8-git-send-email-atull@kernel.org> <20170215172157.GA3317@obsidianresearch.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 15, 2017 at 11:46:01AM -0600, Alan Tull wrote: > On Wed, Feb 15, 2017 at 11:21 AM, Jason Gunthorpe > wrote: > > On Wed, Feb 15, 2017 at 10:14:20AM -0600, Alan Tull wrote: > >> Add a sysfs interface to control programming FPGA. > >> > >> Each fpga-region will get the following files which set values > >> in the fpga_image_info struct for that region. More files will > >> need to be added as fpga_image_info expands. > >> > >> firmware_name > >> * writing a name of a FPGA image file to firmware_name causes the > >> FPGA region to write the FPGA > >> > >> partial_config > >> * 0 : full reconfiguration > >> * 1 : partial reconfiguration > > > > This is really a property of the bitfile. It would be really nice to > > have a saner system for describing the bitfiles that doesn't rely on > > so much out of band stuff. Agreed. > > > > Eg when doing partial reconfiguration it would be really sane to have > > some checks that the full bitfile is the correct basis for the partial > > bitfile. > > > > It also seems link Zynq needs an encrypted/not encrypted flag.. Well, we could also run always at half rate and not benefit from faster config for the non-encrypted case ;-) > > I wonder if we should require a Linux specific header on the bitfile > > instead? That would make the bitfile self describing at least. > I agree. I've heard some discussions about adding a header. We would > want it to not be manufacturer or fpga device specific. That would be > nice and would eliminate some of this struct. We would need a tool to > add the header, given a bitstream and some info about the bitstream. > If the tool communicated seamlessly with vendor's tools that would be > nice, but that is complicated to get that to happen. So far nobody > has posted their proposals to the mailing list. Well, there's not that many vendors out there. If we can figure out a format and stick to it, keep it reasonably extensible, 'the vendors' will eventually adopt it. Cheers, Moritz --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYpJXyAAoJEL5CEHepFqovwrgH+gLVANO3Dy4odFH4nUmypERX ccemHHbAAnchZmBUN9Q/C5xgekdvgR2t7Ng7k0JeS4GDtUAZnEEQB+7e8Zoyrs67 Lykr/HgqVEShZFBSlRDlK5PruwXxb2VS5OSmHpmWwOMGHcW0p7jHmrtI+LKFwDVr 5lTlBq4c3n87O6nwqQOnb5WTwuqmEPdw+Gh7lyI7pAvmt/J4fRDK5evHq3G3mDVu yFtJhF5GWy0ZYcutpbV6kzx/6Zt93aZ83TceF4DdY+Ltx9WDEboVOxeSquXHioXD /3vFpd4ih6Zi7fgKbra3UQTnlP/LuELQ+WNlA1IPjU2IqO5pZx/sBq4tO5Np5w4= =2iw3 -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--