From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934254AbdBQO2U (ORCPT ); Fri, 17 Feb 2017 09:28:20 -0500 Received: from mail.kernel.org ([198.145.29.136]:43856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933976AbdBQO2T (ORCPT ); Fri, 17 Feb 2017 09:28:19 -0500 Date: Fri, 17 Feb 2017 11:28:14 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: David Ahern , Namhyung Kim , Peter Zijlstra , lkml , Ingo Molnar Subject: Re: [PATCH 5/5] perf record: Add -a as a default target Message-ID: <20170217142814.GE4109@kernel.org> References: <1487340058-10496-1-git-send-email-jolsa@kernel.org> <1487340058-10496-6-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487340058-10496-6-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 17, 2017 at 03:00:58PM +0100, Jiri Olsa escreveu: > Adding system wide (-a) option as a default target > if non is specified. > > # perf record > Warning: No target specified, setting system-wide collection (-a). Ditto, this warning will get annoying after a while... > ... > > Signed-off-by: Jiri Olsa > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Link: http://lkml.kernel.org/n/tip-tq11of2qlz8kxpxzva05d54l@git.kernel.org > --- > tools/perf/Documentation/perf-record.txt | 2 +- > tools/perf/builtin-record.c | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt > index 27256bc68eda..b16003ec14a7 100644 > --- a/tools/perf/Documentation/perf-record.txt > +++ b/tools/perf/Documentation/perf-record.txt > @@ -157,7 +157,7 @@ OPTIONS > > -a:: > --all-cpus:: > - System-wide collection from all CPUs. > + System-wide collection from all CPUs (default if no target is specified). > > -p:: > --pid=:: > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 6cd6776052e7..dab23f6b10f3 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1677,8 +1677,10 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused) > > argc = parse_options(argc, argv, record_options, record_usage, > PARSE_OPT_STOP_AT_NON_OPTION); > - if (!argc && target__none(&rec->opts.target)) > - usage_with_options(record_usage, record_options); > + if (!argc && target__none(&rec->opts.target)) { > + pr_warning("Warning: No target specified, setting system-wide collection (-a).\n"); > + rec->opts.target.system_wide = true; > + } > > if (nr_cgroups && !rec->opts.target.system_wide) { > usage_with_options_msg(record_usage, record_options, > -- > 2.7.4