All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v2 0/2] Kernel selftest plumbing
Date: Mon, 13 Mar 2017 13:02:04 +0200	[thread overview]
Message-ID: <20170313110204.e5sgxy7tgogltjsg@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20170313105004.GV28427@nuc-i3427.alporthouse.com>

On Mon, Mar 13, 2017 at 10:50:04AM +0000, Chris Wilson wrote:
> Still completely lacking justification. The above is a non sequitur;
> static testlist generation can be done just from the source.

Static testlist generation can be done and it breaks when run on a
kernel without selftests enabled.

make distcheck fails when running on a kernel without selftests
enabled. It's frankly surprising that CI has been able to build IGT at
all.

I don't know what you mean by "just from the source"? With this series
the subtest enumeration is done "from the source", which wasn't
possible before. It doesn't change behaviour from before when run with
selftests enabled. It makes other machinery work again, the ones that
expect subtest enumeration to work regardless of the runtime
environment. Changing _that_ rule with the kselftest runners is the
one change that is without justification.


--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-03-13 11:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 10:43 [PATCH i-g-t v2 0/2] Kernel selftest plumbing Petri Latvala
2017-03-13 10:43 ` [PATCH i-g-t v2 1/2] lib: Add i915 and drm-mm selftest headers from the kernel Petri Latvala
2017-03-13 10:43 ` [PATCH i-g-t v2 2/2] Always expose IGT subtests for known kernel selftests Petri Latvala
2017-03-13 10:50 ` [PATCH i-g-t v2 0/2] Kernel selftest plumbing Chris Wilson
2017-03-13 11:02   ` Petri Latvala [this message]
2017-03-13 14:15     ` Chris Wilson
2017-03-13 14:29       ` Petri Latvala
2017-03-13 15:06         ` Petri Latvala
2017-03-13 15:06         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313110204.e5sgxy7tgogltjsg@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.