From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753609AbdCOMYR (ORCPT ); Wed, 15 Mar 2017 08:24:17 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35721 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017AbdCOMXF (ORCPT ); Wed, 15 Mar 2017 08:23:05 -0400 Date: Wed, 15 Mar 2017 12:23:00 +0000 From: Lee Jones To: Joe Perches Cc: Linus Walleij , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Message-ID: <20170315122300.jwuogngm6obgvz5z@dell> References: <20170314140455.umlhdbuj3grqtu6i@dell> <1489511868.2582.2.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489511868.2582.2.camel@perches.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2017, Joe Perches wrote: > On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > > On Thu, 16 Feb 2017, Joe Perches wrote: > > > To enable eventual removal of pr_warning > [] > > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > [] > > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > > } > > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > > if (!order) > > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > > - "script before wakeup) Leads to boot"\ > > > - "failure on some boards\n"); > > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > > > Is 80 chars considered the lessor sin? > > Splitting logging messages into multiple lines is non preferred. > > Documentation/process/coding-style.rst: > > Breaking long lines and strings: > > never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. Right, I'm aware of this. I'm also aware of the other rule we have where lines are not to exceed 80 chars. Hence my question; "is the 80 chars rule the lessor sin of the two". Rock <=> hard place Actually I would say that the error message sub-optimal and could, in fact be edited to be more succinct, thus not breaking any rules. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Date: Wed, 15 Mar 2017 12:23:00 +0000 Message-ID: <20170315122300.jwuogngm6obgvz5z@dell> References: <20170314140455.umlhdbuj3grqtu6i@dell> <1489511868.2582.2.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1489511868.2582.2.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joe Perches Cc: Tony Lindgren , Linus Walleij , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gVHVlLCAxNCBNYXIgMjAxNywgSm9lIFBlcmNoZXMgd3JvdGU6Cgo+IE9uIFR1ZSwgMjAxNy0w My0xNCBhdCAxNDowNCArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVGh1LCAxNiBGZWIg MjAxNywgSm9lIFBlcmNoZXMgd3JvdGU6Cj4gPiA+IFRvIGVuYWJsZSBldmVudHVhbCByZW1vdmFs IG9mIHByX3dhcm5pbmcKPiBbXQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvdHdsNDAz MC1wb3dlci5jIGIvZHJpdmVycy9tZmQvdHdsNDAzMC1wb3dlci5jCj4gW10KPiA+ID4gQEAgLTUw Miw5ICs1MDIsNyBAQCBzdGF0aWMgaW50IGxvYWRfdHdsNDAzMF9zY3JpcHQoY29uc3Qgc3RydWN0 IHR3bDQwMzBfcG93ZXJfZGF0YSAqcGRhdGEsCj4gPiA+ICAJfQo+ID4gPiAgCWlmICh0c2NyaXB0 LT5mbGFncyAmIFRXTDQwMzBfU0xFRVBfU0NSSVBUKSB7Cj4gPiA+ICAJCWlmICghb3JkZXIpCj4g PiA+IC0JCQlwcl93YXJuaW5nKCJUV0w0MDMwOiBCYWQgb3JkZXIgb2Ygc2NyaXB0cyAoc2xlZXAg IlwKPiA+ID4gLQkJCQkJInNjcmlwdCBiZWZvcmUgd2FrZXVwKSBMZWFkcyB0byBib290IlwKPiA+ ID4gLQkJCQkJImZhaWx1cmUgb24gc29tZSBib2FyZHNcbiIpOwo+ID4gPiArCQkJcHJfd2Fybigi VFdMNDAzMDogQmFkIG9yZGVyIG9mIHNjcmlwdHMgKHNsZWVwIHNjcmlwdCBiZWZvcmUgd2FrZXVw KSBMZWFkcyB0byBib290IGZhaWx1cmUgb24gc29tZSBib2FyZHNcbiIpOwo+ID4gCj4gPiBJcyA4 MCBjaGFycyBjb25zaWRlcmVkIHRoZSBsZXNzb3Igc2luPwo+IAo+IFNwbGl0dGluZyBsb2dnaW5n IG1lc3NhZ2VzIGludG8gbXVsdGlwbGUgbGluZXMgaXMgbm9uIHByZWZlcnJlZC4KPiAKPiBEb2N1 bWVudGF0aW9uL3Byb2Nlc3MvY29kaW5nLXN0eWxlLnJzdDoKPiAKPiBCcmVha2luZyBsb25nIGxp bmVzIGFuZCBzdHJpbmdzOgo+IAo+IG5ldmVyIGJyZWFrIHVzZXItdmlzaWJsZSBzdHJpbmdzIHN1 Y2ggYXMKPiBwcmludGsgbWVzc2FnZXMsIGJlY2F1c2UgdGhhdCBicmVha3MgdGhlIGFiaWxpdHkg dG8gZ3JlcCBmb3IgdGhlbS4KClJpZ2h0LCBJJ20gYXdhcmUgb2YgdGhpcy4gIEknbSBhbHNvIGF3 YXJlIG9mIHRoZSBvdGhlciBydWxlIHdlIGhhdmUKd2hlcmUgbGluZXMgYXJlIG5vdCB0byBleGNl ZWQgODAgY2hhcnMuICBIZW5jZSBteSBxdWVzdGlvbjsgImlzIHRoZSA4MApjaGFycyBydWxlIHRo ZSBsZXNzb3Igc2luIG9mIHRoZSB0d28iLgoKUm9jayA8PT4gaGFyZCBwbGFjZQoKQWN0dWFsbHkg SSB3b3VsZCBzYXkgdGhhdCB0aGUgZXJyb3IgbWVzc2FnZSBzdWItb3B0aW1hbCBhbmQgY291bGQs IGluCmZhY3QgYmUgZWRpdGVkIHRvIGJlIG1vcmUgc3VjY2luY3QsIHRodXMgbm90IGJyZWFraW5n IGFueSBydWxlcy4gCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFu ZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFS TSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 15 Mar 2017 12:23:00 +0000 Subject: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn In-Reply-To: <1489511868.2582.2.camel@perches.com> References: <20170314140455.umlhdbuj3grqtu6i@dell> <1489511868.2582.2.camel@perches.com> Message-ID: <20170315122300.jwuogngm6obgvz5z@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 14 Mar 2017, Joe Perches wrote: > On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > > On Thu, 16 Feb 2017, Joe Perches wrote: > > > To enable eventual removal of pr_warning > [] > > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > [] > > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > > } > > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > > if (!order) > > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > > - "script before wakeup) Leads to boot"\ > > > - "failure on some boards\n"); > > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > > > Is 80 chars considered the lessor sin? > > Splitting logging messages into multiple lines is non preferred. > > Documentation/process/coding-style.rst: > > Breaking long lines and strings: > > never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. Right, I'm aware of this. I'm also aware of the other rule we have where lines are not to exceed 80 chars. Hence my question; "is the 80 chars rule the lessor sin of the two". Rock <=> hard place Actually I would say that the error message sub-optimal and could, in fact be edited to be more succinct, thus not breaking any rules. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog