From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 20 Mar 2017 07:36:05 -0700 From: Tony Lindgren To: Tero Kristo Cc: mturquette@baylibre.com, linux-omap@vger.kernel.org, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv2 5/9] ARM: OMAP2+: hwmod: assign main clock from DT if available Message-ID: <20170320143605.GI20572@atomide.com> References: <1489741781-12816-1-git-send-email-t-kristo@ti.com> <1489741781-12816-6-git-send-email-t-kristo@ti.com> <20170317154126.GU20572@atomide.com> <20170317221728.GX20572@atomide.com> <95b7142f-8cc7-5909-764e-05dbad434298@ti.com> <20170320143433.GG20572@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170320143433.GG20572@atomide.com> List-ID: * Tony Lindgren [170320 07:37]: > * Tero Kristo [170320 06:25]: > > On 18/03/17 00:17, Tony Lindgren wrote: > > > I don't quite follow you, what breaks if you fall back to the old clock > > > lookup if no "ti,hwmods" is set? > > > > I think I misunderstood your earlier comment. So basically the code already > > bails out early if ti,hwmods is not set. In this case, the earlier lookup > > done by hwmod core sets the node pointer for this code to be NULL, and this > > just parses the existing main_clk info. > > OK thanks for confirming that. And also for this patch: Acked-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 20 Mar 2017 07:36:05 -0700 Subject: [PATCHv2 5/9] ARM: OMAP2+: hwmod: assign main clock from DT if available In-Reply-To: <20170320143433.GG20572@atomide.com> References: <1489741781-12816-1-git-send-email-t-kristo@ti.com> <1489741781-12816-6-git-send-email-t-kristo@ti.com> <20170317154126.GU20572@atomide.com> <20170317221728.GX20572@atomide.com> <95b7142f-8cc7-5909-764e-05dbad434298@ti.com> <20170320143433.GG20572@atomide.com> Message-ID: <20170320143605.GI20572@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Tony Lindgren [170320 07:37]: > * Tero Kristo [170320 06:25]: > > On 18/03/17 00:17, Tony Lindgren wrote: > > > I don't quite follow you, what breaks if you fall back to the old clock > > > lookup if no "ti,hwmods" is set? > > > > I think I misunderstood your earlier comment. So basically the code already > > bails out early if ti,hwmods is not set. In this case, the earlier lookup > > done by hwmod core sets the node pointer for this code to be NULL, and this > > just parses the existing main_clk info. > > OK thanks for confirming that. And also for this patch: Acked-by: Tony Lindgren