From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbdC0X4Z (ORCPT ); Mon, 27 Mar 2017 19:56:25 -0400 Received: from mail.kernel.org ([198.145.29.136]:50348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbdC0X4T (ORCPT ); Mon, 27 Mar 2017 19:56:19 -0400 Date: Mon, 27 Mar 2017 16:56:08 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 3/3] f2fs: prevent waiter encountering incorrect discard states Message-ID: <20170327235608.GA4984@jaegeuk.local> References: <20170327101406.56028-1-yuchao0@huawei.com> <20170327101406.56028-3-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327101406.56028-3-yuchao0@huawei.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27, Chao Yu wrote: > In f2fs_submit_discard_endio, we will wake up waiter before setting > discard command states, so waiter may use incorrect states. Change > the order between complete() and states setting to fix this issue. > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 57a81f9c8c14..9f9542c9fe47 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -717,9 +717,9 @@ static void f2fs_submit_discard_endio(struct bio *bio) > { > struct discard_cmd *dc = (struct discard_cmd *)bio->bi_private; > > - complete(&dc->wait); > dc->error = bio->bi_error; > dc->state = D_DONE; > + complete(&dc->wait); If we set D_DONE first, the object can be released by __remove_discard_cmd()? Thanks, > bio_put(bio); > } > > -- > 2.8.2.295.g3f1c1d0