From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932169AbdC1LEG (ORCPT ); Tue, 28 Mar 2017 07:04:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56255 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932139AbdC1LEF (ORCPT ); Tue, 28 Mar 2017 07:04:05 -0400 From: Ravi Bangoria To: acme@redhat.com, mhiramat@kernel.org Cc: alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au, hemant@linux.vnet.ibm.com, Ravi Bangoria Subject: [PATCH v3 0/3] perf/sdt: Hardening argument support Date: Tue, 28 Mar 2017 15:17:51 +0530 X-Mailer: git-send-email 2.9.3 X-TM-AS-MML: disable x-cbid: 17032809-0040-0000-0000-00000301C370 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032809-0041-0000-0000-00000C78B170 Message-Id: <20170328094754.3156-1-ravi.bangoria@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-28_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280090 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SDT event argument support on x86 is recently added to Perf. But there are couple of issues with it. It lacks renaming mapping for few 8 bit registers: al, bl, cl, dl, ah, bh, ch and dh. SDT events using these registers in arguments are failing at 'perf probe'. Add renaming logic to them. (patch 1) It still has x86 specific code in general code. It also fails to convert arguments having no offset but still surrounds register with parenthesis for ex. 8@(%rdi) is converted to +(%di):u64, which is rejected by uprobe_events. Also, 'perf probe' is failing for *all SDT events on all archs except x86*. Solve these issues. (patch 2) Add argument parser for powerpc. (patch 3) Changes in v3: - (patch 1) Add renaming entries for ah, bh, ch and dh registers.[1] - (patch 1) v2 contains silly copy-paste error. It maps all al, bl... registers to ax. Fix that. - (patch 2) Fix typo 'constant'. - Patch 2 is not applying cleanly on top of patch 1 after adding ah, bh... registers. Fix that. v2: https://lkml.org/lkml/2017/3/27/118 This patch is prepared on top of acme/perf/core. [1] https://lkml.org/lkml/2017/3/27/462 Ravi Bangoria (3): perf/sdt/x86: Add renaming logic for (missing) 8 bit registers perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ perf/sdt/powerpc: Add argument support tools/perf/arch/powerpc/util/perf_regs.c | 111 ++++++++++++++++++ tools/perf/arch/x86/util/perf_regs.c | 187 +++++++++++++++++++++++++------ tools/perf/util/perf_regs.c | 6 +- tools/perf/util/perf_regs.h | 11 +- tools/perf/util/probe-file.c | 132 +++++++--------------- 5 files changed, 313 insertions(+), 134 deletions(-) -- 2.9.3