From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] board: samsung: trats: convert to driver model for controlling phy
Date: Thu, 30 Mar 2017 21:29:59 +0900 [thread overview]
Message-ID: <20170330123002.21207-4-jh80.chung@samsung.com> (raw)
In-Reply-To: <20170330123002.21207-1-jh80.chung@samsung.com>
Convert to driver model for controlling phy.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
board/samsung/trats/trats.c | 75 +++++++++++++++++++++++++++++----------------
1 file changed, 48 insertions(+), 27 deletions(-)
diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index fa297c3..be5e2e2 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -23,6 +23,7 @@
#include <power/max8997_muic.h>
#include <power/battery.h>
#include <power/max17042_fg.h>
+#include <power/pmic.h>
#include <libtizen.h>
#include <usb.h>
#include <usb_mass_storage.h>
@@ -232,39 +233,59 @@ static void check_hw_revision(void)
#ifdef CONFIG_USB_GADGET
static int s5pc210_phy_control(int on)
{
-#ifndef CONFIG_DM_I2C /* TODO(maintainer): Convert to driver model */
- int ret = 0;
- u32 val = 0;
- struct pmic *p = pmic_get("MAX8997_PMIC");
- if (!p)
- return -ENODEV;
+ struct udevice *dev;
+ int reg, ret;
- if (pmic_probe(p))
- return -1;
+ ret = pmic_get("max8997-pmic", &dev);
+ if (ret)
+ return ret;
if (on) {
- ret |= pmic_set_output(p, MAX8997_REG_SAFEOUTCTRL,
- ENSAFEOUT1, LDO_ON);
- ret |= pmic_reg_read(p, MAX8997_REG_LDO3CTRL, &val);
- ret |= pmic_reg_write(p, MAX8997_REG_LDO3CTRL, EN_LDO | val);
-
- ret |= pmic_reg_read(p, MAX8997_REG_LDO8CTRL, &val);
- ret |= pmic_reg_write(p, MAX8997_REG_LDO8CTRL, EN_LDO | val);
+ reg = pmic_reg_read(dev, MAX8997_REG_SAFEOUTCTRL);
+ reg |= ENSAFEOUT1;
+ ret = pmic_reg_write(dev, MAX8997_REG_SAFEOUTCTRL, reg);
+ if (ret) {
+ puts("MAX8997 setting error!\n");
+ return ret;
+ }
+ reg = pmic_reg_read(dev, MAX8997_REG_LDO3CTRL);
+ reg |= EN_LDO;
+ ret = pmic_reg_write(dev, MAX8997_REG_LDO3CTRL, reg);
+ if (ret) {
+ puts("MAX8997 setting error!\n");
+ return ret;
+ }
+ reg = pmic_reg_read(dev, MAX8997_REG_LDO8CTRL);
+ reg |= EN_LDO;
+ ret = pmic_reg_write(dev, MAX8997_REG_LDO8CTRL, reg);
+ if (ret) {
+ puts("MAX8997 setting error!\n");
+ return ret;
+ }
} else {
- ret |= pmic_reg_read(p, MAX8997_REG_LDO8CTRL, &val);
- ret |= pmic_reg_write(p, MAX8997_REG_LDO8CTRL, DIS_LDO | val);
-
- ret |= pmic_reg_read(p, MAX8997_REG_LDO3CTRL, &val);
- ret |= pmic_reg_write(p, MAX8997_REG_LDO3CTRL, DIS_LDO | val);
- ret |= pmic_set_output(p, MAX8997_REG_SAFEOUTCTRL,
- ENSAFEOUT1, LDO_OFF);
- }
+ reg = pmic_reg_read(dev, MAX8997_REG_LDO8CTRL);
+ reg &= DIS_LDO;
+ ret = pmic_reg_write(dev, MAX8997_REG_LDO8CTRL, reg);
+ if (ret) {
+ puts("MAX8997 setting error!\n");
+ return ret;
+ }
+ reg = pmic_reg_read(dev, MAX8997_REG_LDO3CTRL);
+ reg &= DIS_LDO;
+ ret = pmic_reg_write(dev, MAX8997_REG_LDO3CTRL, reg);
+ if (ret) {
+ puts("MAX8997 setting error!\n");
+ return ret;
+ }
+ reg = pmic_reg_read(dev, MAX8997_REG_SAFEOUTCTRL);
+ reg &= ~ENSAFEOUT1;
+ ret = pmic_reg_write(dev, MAX8997_REG_SAFEOUTCTRL, reg);
+ if (ret) {
+ puts("MAX8997 setting error!\n");
+ return ret;
+ }
- if (ret) {
- puts("MAX8997 LDO setting error!\n");
- return -1;
}
-#endif
return 0;
}
--
2.10.2
next prev parent reply other threads:[~2017-03-30 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170330123003epcas5p2558c23e6cf90bd0189d167e0e14665c9@epcas5p2.samsung.com>
2017-03-30 12:29 ` [U-Boot] [PATCH 0/6] trats: convert to driver model Jaehoon Chung
[not found] ` <CGME20170330123003epcas5p282355c963b1c04b5deaba96f83def8f3@epcas5p2.samsung.com>
2017-03-30 12:29 ` [U-Boot] [PATCH 1/6] configs: trats: enable the CONFIG_DM_PMIC and PMIC_MAX8997 Jaehoon Chung
[not found] ` <CGME20170330123003epcas5p49830cf6a7d8d50aa1f3d44992a23220d@epcas5p4.samsung.com>
2017-03-30 12:29 ` [U-Boot] [PATCH 2/6] board: samsung: trats: remove the unnecessary codes Jaehoon Chung
[not found] ` <CGME20170330123003epcas5p2f301ccfd243c454b97f21694f2fd82a3@epcas5p2.samsung.com>
2017-03-30 12:29 ` Jaehoon Chung [this message]
2017-04-01 4:23 ` [U-Boot] [PATCH 3/6] board: samsung: trats: convert to driver model for controlling phy Simon Glass
[not found] ` <CGME20170330123003epcas5p29001037283e19fcdcdfaf99f96816bd7@epcas5p2.samsung.com>
2017-03-30 12:30 ` [U-Boot] [PATCH 4/6] arm: dts: trats: add i2c_fg node for fuelgauge Jaehoon Chung
[not found] ` <CGME20170330123003epcas5p4d59106adf0ca9ee6fd12a34f2581605c@epcas5p4.samsung.com>
2017-03-30 12:30 ` [U-Boot] [PATCH 5/6] board: samsung: trats: remove the i2c_init function Jaehoon Chung
2017-04-01 4:23 ` Simon Glass
[not found] ` <CGME20170330123003epcas5p2c6acfec92524c3600acf8c9dd8583f0c@epcas5p2.samsung.com>
2017-03-30 12:30 ` [U-Boot] [PATCH 6/6] configs: trats: enable the CONFIG_DM_I2C_GPIO Jaehoon Chung
2017-04-01 4:23 ` Simon Glass
2017-03-30 13:09 ` [U-Boot] [PATCH 0/6] trats: convert to driver model Lukasz Majewski
2017-04-03 7:25 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330123002.21207-4-jh80.chung@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.