From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750792AbdDAEIt (ORCPT ); Sat, 1 Apr 2017 00:08:49 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38220 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbdDAEIs (ORCPT ); Sat, 1 Apr 2017 00:08:48 -0400 Date: Sat, 1 Apr 2017 05:08:42 +0100 From: Al Viro To: Joe Perches Cc: Chewie Lin , greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Message-ID: <20170401040842.GF29622@ZenIV.linux.org.uk> References: <20170401015919.9181-1-linsh@oregonstate.edu> <20170401015919.9181-2-linsh@oregonstate.edu> <20170401033239.GD29622@ZenIV.linux.org.uk> <1491017782.27353.33.camel@perches.com> <20170401034623.GE29622@ZenIV.linux.org.uk> <1491018770.27353.35.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491018770.27353.35.camel@perches.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 08:52:50PM -0700, Joe Perches wrote: > > MILD SUGGESTION: don't spell the function name out in format strings; > > "this_function: foo is %d", n > > might be better off as > > "%s: foo is %d", __func__, n > > in case you ever move it to another function or rename your function. > > Thank you sir, may I have another. > > checkpatch messages are single line. Too bad... Incidentally, being able to get more detailed explanation of a warning might be a serious improvement, especially if it contains the rationale. Hell, something like TeX handling of errors might be a good idea - warning printed, offered actions include 'give more help', 'continue', 'exit', 'from now on suppress this kind of warning', 'from now on just dump this kind of warning into log and keep going', 'from now on dump all warnings into log and keep going'. And yes, I'm serious about having something like "mild suggestion" as possible severity - people are using that thing to look for potential improvements to make and 'such and such change might be useful for such and such reasons' is a lot more useful than 'this needs to be thus because it must be thus or I'll keep warning'.