All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tuomas Tynkkynen <tuomas@tuxera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] regression: setting the rpi mac address stopped working
Date: Sat, 1 Apr 2017 17:49:44 +0300	[thread overview]
Message-ID: <20170401174944.36f2783e@duuni> (raw)
In-Reply-To: <CAPnjgZ1QPVx29kSAZOsDezzUz8x_DAmxR9m-i=xdjgMbJVptdw@mail.gmail.com>

Hi Simon, Gerd

On Fri, 31 Mar 2017 22:22:52 -0600
Simon Glass <sjg@chromium.org> wrote:

> Hi,
> 
> On 27 March 2017 at 02:24, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >   Hi,
> >
> > u-boot 2016.11 & newer doesn't set the mac address on my raspberry pi
> > any more, so the linux kernel picks a random mac address.  Bisected to
> > this commit:
> >
> > commit b91c6a1209e7da1a7f989d9ac35d0d8be0b7b710
> > Author: Simon Glass <sjg@chromium.org>
> > Date:   Wed Oct 5 20:42:11 2016 -0600
> >
> >     Fix return value in trailing_strtoln()
> >
> >     This function should return -1 if there is no trailing integer
> >     in the string. Instead it returns 0. Fix it by checking for this
> >     condition at the start.
> >
> >     Signed-off-by: Simon Glass <sjg@chromium.org>
> >     Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Appearently this change broke fdt_fixup_ethernet().  
> 
> I'm sorry to hear that. Any change you have a patch? It looks like the
> latter code was relying on the bad behaviour?
> 

https://www.mail-archive.com/u-boot at lists.denx.de/msg241949.html fixes this
problem.

  reply	other threads:[~2017-04-01 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  8:24 [U-Boot] regression: setting the rpi mac address stopped working Gerd Hoffmann
2017-04-01  4:22 ` Simon Glass
2017-04-01 14:49   ` Tuomas Tynkkynen [this message]
2017-04-24 12:12     ` Gerd Hoffmann
2017-04-26 19:30       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170401174944.36f2783e@duuni \
    --to=tuomas@tuxera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.