Re: [PATCH 02/15] drm: Remove drm_modeset_(un)lock_crtc

From: kbuild test robot <lkp@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	kbuild-all@01.org,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 02/15] drm: Remove drm_modeset_(un)lock_crtc
Date: Tue, 4 Apr 2017 06:13:31 +0800	[thread overview]
Message-ID: <201704040605.O6o8sCIh%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170403083304.9083-3-daniel.vetter@ffwll.ch>

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

Hi Daniel,

[auto build test ERROR on next-20170330]
[cannot apply to drm/drm-next drm-intel/for-linux-next robclark/msm-next v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Vetter/acquire-ctx-wire-up-part-2/20170404-053514
config: i386-randconfig-x010-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_du_crtc_cursor_set2':
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:158:2: error: implicit declaration of function 'drm_modeset_unlock_crtc' [-Werror=implicit-function-declaration]
     drm_modeset_unlock_crtc(crtc);
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:228:2: error: implicit declaration of function 'drm_modeset_lock_crtc' [-Werror=implicit-function-declaration]
     drm_modeset_lock_crtc(crtc, crtc->cursor);
     ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/drm_modeset_unlock_crtc +158 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

bfb89928 Daniel Vetter    2012-12-02  152  	 * FIXME: Unclear whether there's any global state touched by the
bfb89928 Daniel Vetter    2012-12-02  153  	 * cursor_set function, especially vmw_cursor_update_position looks
bfb89928 Daniel Vetter    2012-12-02  154  	 * suspicious. For now take the easy route and reacquire all locks. We
bfb89928 Daniel Vetter    2012-12-02  155  	 * can do this since the caller in the drm core doesn't check anything
bfb89928 Daniel Vetter    2012-12-02  156  	 * which is protected by any looks.
bfb89928 Daniel Vetter    2012-12-02  157  	 */
21e88620 Rob Clark        2014-10-30 @158  	drm_modeset_unlock_crtc(crtc);
bfb89928 Daniel Vetter    2012-12-02  159  	drm_modeset_lock_all(dev_priv->dev);
8fbf9d92 Thomas Hellstrom 2015-11-26  160  	hotspot_x = hot_x + du->hotspot_x;
8fbf9d92 Thomas Hellstrom 2015-11-26  161  	hotspot_y = hot_y + du->hotspot_y;

:::::: The code at line 158 was first introduced by commit
:::::: 21e88620aa21b48d4f62d29275e3e2944a5ea2b5 drm/vmwgfx: fix lock breakage

:::::: TO: Rob Clark <robdclark@gmail.com>
:::::: CC: Thomas Hellstrom <thellstrom@vmware.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27264 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx