From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbdDDI1p (ORCPT ); Tue, 4 Apr 2017 04:27:45 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:35059 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdDDI1n (ORCPT ); Tue, 4 Apr 2017 04:27:43 -0400 Date: Tue, 4 Apr 2017 09:27:39 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland Subject: Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip Message-ID: <20170404082739.6w6ltgdr2mgaqq4l@dell> References: <20170401071854.23198-1-javier@osg.samsung.com> <20170401071854.23198-6-javier@osg.samsung.com> <20170403111540.7k3rjucvcxe5cunf@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Apr 2017, Javier Martinez Canillas wrote: > Hello Lee, > > On 04/03/2017 07:15 AM, Lee Jones wrote: > > [snip] > > >> + > >> +The TP61050/TPS61052 is a high-power "white LED driver". This boost converter > >> +is also used for other things than white LEDs, and also contains a GPIO pin. > > > > What functions does it offer? > > > > Same comment than before, I'm not really familiar with this driver. But I'll > look what are the MFD cell instantiated to better understand dev functions > and expand this documentation accordingly. Writing documentation for H/W you are unfamiliar with is a bad idea IMHO. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog