All of lore.kernel.org
 help / color / mirror / Atom feed
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH v2] nvme_fc: avoid double kfree(), don't call nvme_cleanup_cmd() in nvme_fc_unmap_data()
Date: Thu, 6 Apr 2017 20:17:43 +0200	[thread overview]
Message-ID: <20170406181743.GB8215@linux-x5ow.site> (raw)
In-Reply-To: <1491497276-15944-1-git-send-email-emilne@redhat.com>

On Thu, Apr 06, 2017@12:47:56PM -0400, Ewan Milne wrote:
> nvme_cleanup_cmd() is already called by callers of nvme_fc_unmap_data().
> Don't call it twice to avoid double-free on completion of discard commands.
> 
> v2:
> Move nvme_cleanup_cmd() call *after* nvme_fc_unmap_data() for consistency.
> 
> Signed-off-by: Ewan D. Milne <emilne at redhat.com>
> ---

Thanks,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  reply	other threads:[~2017-04-06 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 16:47 [PATCH v2] nvme_fc: avoid double kfree(), don't call nvme_cleanup_cmd() in nvme_fc_unmap_data() Ewan D. Milne
2017-04-06 18:17 ` Johannes Thumshirn [this message]
2017-04-07  7:27 ` Christoph Hellwig
2017-04-09 12:28 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406181743.GB8215@linux-x5ow.site \
    --to=jthumshirn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.