From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755359AbdDLT5W (ORCPT ); Wed, 12 Apr 2017 15:57:22 -0400 Received: from mail.kernel.org ([198.145.29.136]:57686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754445AbdDLT5V (ORCPT ); Wed, 12 Apr 2017 15:57:21 -0400 Date: Wed, 12 Apr 2017 12:57:16 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 2/3] f2fs: shrink blk plug region Message-ID: <20170412195716.GA12163@jaegeuk.local> References: <20170327101406.56028-1-yuchao0@huawei.com> <20170327101406.56028-2-yuchao0@huawei.com> <01ed1c10-f698-8e8c-2f76-f7c61265a844@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01ed1c10-f698-8e8c-2f76-f7c61265a844@huawei.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12, Chao Yu wrote: > Hi Jaegeuk, > > Just reminding, miss merging this patch? :) Yup, merged. ;) > > Thanks, > > On 2017/3/27 18:14, Chao Yu wrote: > > Don't use blk plug covering area where there won't be any IOs being issued. > > > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/segment.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > index c1a03b0857f9..57a81f9c8c14 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -848,9 +848,8 @@ static int issue_discard_thread(void *data) > > if (kthread_should_stop()) > > return 0; > > > > - blk_start_plug(&plug); > > - > > mutex_lock(&dcc->cmd_lock); > > + blk_start_plug(&plug); > > list_for_each_entry_safe(dc, tmp, pend_list, list) { > > f2fs_bug_on(sbi, dc->state != D_PREP); > > > > @@ -860,6 +859,7 @@ static int issue_discard_thread(void *data) > > if (iter++ > DISCARD_ISSUE_RATE) > > break; > > } > > + blk_finish_plug(&plug); > > > > list_for_each_entry_safe(dc, tmp, wait_list, list) { > > if (dc->state == D_DONE) > > @@ -867,8 +867,6 @@ static int issue_discard_thread(void *data) > > } > > mutex_unlock(&dcc->cmd_lock); > > > > - blk_finish_plug(&plug); > > - > > iter = 0; > > congestion_wait(BLK_RW_SYNC, HZ/50); > > > >