All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-next 8/8] x86/domain: move HVM specific code to hvm/domain.c
Date: Mon, 24 Apr 2017 14:12:27 +0100	[thread overview]
Message-ID: <20170424131227.tjellwcwi4qjdfhv@dhcp-3-128.uk.xensource.com> (raw)
In-Reply-To: <58FE0E86020000780015393D@prv-mh.provo.novell.com>

On Mon, Apr 24, 2017 at 06:41:10AM -0600, Jan Beulich wrote:
> >>> On 10.04.17 at 15:27, <wei.liu2@citrix.com> wrote:
> > There is only one function arch_set_info_hvm_guest is moved. The
> > check_segment function is also moved since arch_set_info_hvm_guest is
> > the only user.
> > 
> > No functional change.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Same comment regarding the odd copyright copy.

I was the one that added both functions, and I can attest it's not based on
Linus/Greg code in any way, could you please replace the header with:

/*
 * HVM domain specific functions.
 *
 * Copyright (C) 2017 Citrix Systems R&D
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms and conditions of the GNU General Public
 * License, version 2, as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public
 * License along with this program; If not, see <http://www.gnu.org/licenses/>.
 */

Or similar (I don't think spelling out my name is required).

Thanks, Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2017-04-24 13:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 13:27 [PATCH for-next 0/8] Refactor x86/domain.c Wei Liu
2017-04-10 13:27 ` [PATCH for-next 1/8] xen.h: fix comment for vcpu_guest_context Wei Liu
2017-04-24  9:51   ` Jan Beulich
2017-04-24 10:24     ` Julien Grall
2017-04-24 10:42     ` Wei Liu
2017-04-24 12:29       ` Jan Beulich
2017-04-24 12:55         ` Wei Liu
2017-04-10 13:27 ` [PATCH for-next 2/8] x86/domain: factor out pv_vcpu_initialise Wei Liu
2017-04-24  9:57   ` Jan Beulich
2017-04-24 11:16     ` Wei Liu
2017-04-10 13:27 ` [PATCH for-next 3/8] x86/domain: factor out pv_vcpu_destroy Wei Liu
2017-04-24  9:59   ` Jan Beulich
2017-04-10 13:27 ` [PATCH for-next 4/8] x86/domain: push some code down to hvm_domain_initialise Wei Liu
2017-04-10 15:19   ` Andrew Cooper
2017-04-25 12:15     ` Wei Liu
2017-04-24 10:10   ` Jan Beulich
2017-04-24 14:55     ` Wei Liu
2017-04-10 13:27 ` [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy Wei Liu
2017-04-10 15:04   ` Andrew Cooper
2017-04-10 15:12     ` Wei Liu
2017-04-10 15:16       ` Andrew Cooper
2017-04-10 15:22         ` Wei Liu
2017-04-10 15:27           ` Andrew Cooper
2017-04-24 10:11   ` Jan Beulich
2017-04-10 13:27 ` [PATCH for-next 6/8] x86/domain: factor out pv_domain_initialise Wei Liu
2017-04-24 10:20   ` Jan Beulich
2017-04-25 13:37     ` Wei Liu
2017-04-10 13:27 ` [PATCH for-next 7/8] x86/domain: move PV specific code to pv/domain.c Wei Liu
2017-04-24 12:39   ` Jan Beulich
2017-04-24 14:24     ` Wei Liu
2017-04-24 15:57       ` Jan Beulich
2017-04-10 13:27 ` [PATCH for-next 8/8] x86/domain: move HVM specific code to hvm/domain.c Wei Liu
2017-04-24 12:41   ` Jan Beulich
2017-04-24 13:12     ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424131227.tjellwcwi4qjdfhv@dhcp-3-128.uk.xensource.com \
    --to=roger.pau@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.