From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Jeffrey Walton" <noloader@gmail.com>,
"Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>,
"J Smith" <dark.panda@gmail.com>,
"Victor Leschuk" <vleschuk@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Fredrik Kuivinen" <frekui@gmail.com>,
"Zoltán Herczeg" <hzmester@freemail.hu>,
"Brandon Williams" <bmwill@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v4 00/19] PCRE v1 improvements & PCRE v2 support
Date: Tue, 25 Apr 2017 21:05:29 +0000 [thread overview]
Message-ID: <20170425210548.24612-1-avarab@gmail.com> (raw)
Trivial changes since last time. Just sending this because I'd like
the copy in pu updated. Changes noted below:
Ævar Arnfjörð Bjarmason (19):
grep: amend submodule recursion test in preparation for rx engine
testing
grep: add tests for grep pattern types being passed to submodules
A s/PCRE/LIBPCRE/ on the test_have_prereq, now makes sense with the
series in sequence (error added during rebasing).
grep: submodule-related case statements should die if new fields are
added
grep: remove redundant regflags assignment under PCRE
grep: remove redundant `regflags &= ~REG_EXTENDED` assignments
NEW: Similarly to how we didn't need to set regflags under PCRE, we
were negating REG_EXTENDED under POSIX basic, without ever setting it
in the first place.
This was just as confusing as the PCRE oddity, so remove it.
Makefile & configure: reword outdated comment about PCRE
grep: add a test for backreferences in PCRE patterns
log: add exhaustive tests for pattern style options & config
log: add -P as a synonym for --perl-regexp
grep & rev-list doc: stop promising libpcre for --perl-regexp
grep: make grep.patternType=[pcre|pcre1] a synonym for "perl"
test-lib: rename the LIBPCRE prerequisite to PCRE
One corresponding s/LIBPCRE/PCRE/ for the earlier change, see above.
grep: change the internal PCRE macro names to be PCRE1
grep: change the internal PCRE code & header names to be PCRE1
perf: add a performance comparison test of grep -E and -P
grep: add support for the PCRE v1 JIT API
grep: add support for PCRE v2
We now give proper error messages via pcre2_get_error_message() when
pcre2_match() fails with errors other than "didn't match", the common
case for this is that the engine gave up on a pathological pattern /
input combination.
grep: remove support for concurrent use of both PCRE v1 & v2
Makefile & configure: make PCRE v2 the default PCRE implementation
Added more details to the commit message about why switching to PCRE
v2 by default is a good idea. I hadn't noticed before that deep bugs
in PCRE v1 are being WONTFIX'd on the bugtracker saying "nope, never
fixing thath in v1, switch to v2".
Documentation/git-grep.txt | 7 +-
Documentation/rev-list-options.txt | 9 +-
Makefile | 39 +++++--
builtin/grep.c | 4 +
configure.ac | 81 ++++++++++++--
grep.c | 222 +++++++++++++++++++++++++++++++------
grep.h | 32 +++++-
revision.c | 2 +-
t/README | 4 +-
t/perf/p7820-grep-engines.sh | 25 +++++
t/t4202-log.sh | 86 +++++++++++++-
t/t7810-grep.sh | 41 ++++---
t/t7812-grep-icase-non-ascii.sh | 4 +-
t/t7813-grep-icase-iso.sh | 11 +-
t/t7814-grep-recurse-submodules.sh | 215 +++++++++++++++++++++--------------
t/test-lib.sh | 3 +-
16 files changed, 613 insertions(+), 172 deletions(-)
create mode 100755 t/perf/p7820-grep-engines.sh
--
2.11.0
next reply other threads:[~2017-04-25 21:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 21:05 Ævar Arnfjörð Bjarmason [this message]
2017-04-25 21:05 ` [PATCH v4 01/19] grep: amend submodule recursion test in preparation for rx engine testing Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 02/19] grep: add tests for grep pattern types being passed to submodules Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 03/19] grep: submodule-related case statements should die if new fields are added Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 04/19] grep: remove redundant regflags assignment under PCRE Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 05/19] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments Ævar Arnfjörð Bjarmason
2017-04-26 4:50 ` Junio C Hamano
2017-04-26 5:29 ` Junio C Hamano
2017-04-26 7:48 ` [PATCH v5 " Ævar Arnfjörð Bjarmason
2017-04-27 0:51 ` Junio C Hamano
2017-04-25 21:05 ` [PATCH v4 06/19] Makefile & configure: reword outdated comment about PCRE Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 07/19] grep: add a test for backreferences in PCRE patterns Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 08/19] log: add exhaustive tests for pattern style options & config Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 09/19] log: add -P as a synonym for --perl-regexp Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 10/19] grep & rev-list doc: stop promising libpcre " Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 11/19] grep: make grep.patternType=[pcre|pcre1] a synonym for "perl" Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 12/19] test-lib: rename the LIBPCRE prerequisite to PCRE Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 13/19] grep: change the internal PCRE macro names to be PCRE1 Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 14/19] grep: change the internal PCRE code & header " Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 15/19] perf: add a performance comparison test of grep -E and -P Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 16/19] grep: add support for the PCRE v1 JIT API Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 17/19] grep: add support for PCRE v2 Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 18/19] grep: remove support for concurrent use of both PCRE v1 & v2 Ævar Arnfjörð Bjarmason
2017-04-25 21:05 ` [PATCH v4 19/19] Makefile & configure: make PCRE v2 the default PCRE implementation Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425210548.24612-1-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=dark.panda@gmail.com \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hzmester@freemail.hu \
--cc=michal.kiedrowicz@gmail.com \
--cc=noloader@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=vleschuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.