All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>,
	Brian Foster <bfoster@redhat.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: handle large CoW remapping requests
Date: Tue, 2 May 2017 00:50:21 -0700	[thread overview]
Message-ID: <20170502075021.GA7916@infradead.org> (raw)
In-Reply-To: <20170427212754.GB19158@birch.djwong.org>

On Thu, Apr 27, 2017 at 02:27:54PM -0700, Darrick J. Wong wrote:
> XFS transactions are constrained both by space and block reservation
> limits and the fact that we have to avoid doing 64-bit divisions.  This
> means that we can't remap more than 2^32 blocks at a time.  However,
> file logical blocks are 64-bit in size, so if we encounter a huge remap
> request we have to break it up into smaller pieces.

But where would we get that huge remap request from?  We already did the
BUILD_BUG_ON for the max read/write size at least.  Also the remaps
would now not be atomic, which would be a problem for my O_ATOMIC
implementation at least.

  reply	other threads:[~2017-05-02  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 21:27 [PATCH] xfs: handle large CoW remapping requests Darrick J. Wong
2017-05-02  7:50 ` Christoph Hellwig [this message]
2017-05-02 18:02   ` Darrick J. Wong
2017-05-04 11:54     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170502075021.GA7916@infradead.org \
    --to=hch@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.