From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164AbdEDFku (ORCPT ); Thu, 4 May 2017 01:40:50 -0400 Received: from merlin.infradead.org ([205.233.59.134]:32892 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbdEDFkl (ORCPT ); Thu, 4 May 2017 01:40:41 -0400 Date: Thu, 4 May 2017 07:40:30 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Ingo Molnar , Linux Kernel Mailing List , Thomas Gleixner , "Paul E. McKenney" , Andrew Morton , Greg Kroah-Hartman Subject: Re: [GIT PULL] locking fixes Message-ID: <20170504054030.qghlje7odni7zbt5@hirez.programming.kicks-ass.net> References: <20170228075747.GA10419@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 04:21:01PM -0700, Linus Torvalds wrote: > This is from last merge window, and the reason I react now is that > nobody noticed or cared until we had a release.. > > On Mon, Feb 27, 2017 at 11:57 PM, Ingo Molnar wrote: > > > > Peter Zijlstra (1): > > locking/refcounts: Out-of-line everything > > This one is all good generally, but it has one really stupid side > effect: it makes refcounting GPL-only. > > That's just silly. These are functions that atomically add and > subtract one. The only thing that making them GPL-only can possibly do > is to make people hack around it, and lose the overflow handling > debugging in the process. These people are out-of-tree dubious licensed modules, right? I really _really_ don't care about those. > It also breaks any kref uses. Which is what drivers etc are supposed to use. Greg KH had this to say: "As all of the previous kref functions were in a GPL-only header file, and included directly that way, they were already GPL-only symbols, so there really was no change here except now the linker checks them. If you have questions about using inline GPL-only functions from a .h file, in a non-GPL codebase, please consult your corporate lawyer to get clarification." https://lkml.kernel.org/r/20170308094810.GB30552@kroah.com > So that "move from inline to out-of-line" had a big subtle semantic > change that was probably not intentional, and certainly not > documented. I'll take the not documented bit.