Re: [PATCH 0/1] mesa: Contain configure search for llvm

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 6491 bytes --]

On Tue, Jun 13, 2017 at 03:13:01PM -0700, Khem Raj wrote:
> On Tue, Jun 13, 2017 at 2:39 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Sat, Apr 01, 2017 at 08:21:16AM -0700, Khem Raj wrote:
> >> On Fri, Mar 31, 2017 at 10:52 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> > Why is it needed?
> >>
> >> If you have clang/llvm installed on your build host then it defaults to that
> >> thats why its needed.
> >
> > And where does meta-clang install it? Because if it doesn't match with
> > the location used by meta-oe's llvm then we cannot have the same flag
> > which suits both providers.
> >
> > As it is now I still have this change reverted in my branches and I've
> > noticed some layers which just use EXTRA_OECONF_remove to just remove
> > this with-llvm-prefix to unblock the builds with Pyro and Rocko.
> >
> >> > Without this change mesa was finding llvm-config correctly, that's why I've
> >> > just reverted this to continue building.
> 
> The problem is mainly when you have clang/llvm installed on build host
> now that we prune hosttools this might not be an issue anymore, although
> this needs to be tested.

I'm not using meta-clang anywhere, can you please answer where
meta-clang installs llvm-config and if it's different path than what
meta-oe recipe does, can we unify them?

Unifying them was also discussed here:
https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg94412.html
but as I'm using meta-oe's llvm just for mesa I cannot help much with
that.

Regards,

> >> > On Fri, Mar 31, 2017 at 5:57 PM, Khem Raj <raj.khem@gmail.com> wrote:
> >> >>
> >> >> On Fri, Mar 31, 2017 at 8:08 AM, Martin Jansa <martin.jansa@gmail.com>
> >> >> wrote:
> >> >> > On Thu, Mar 23, 2017 at 10:31:07AM -0700, Khem Raj wrote:
> >> >> >> On Thu, Mar 23, 2017 at 12:51 AM, Martin Jansa <martin.jansa@gmail.com>
> >> >> >> wrote:
> >> >> >> > I'm not sure if this is the root cause, but last qemux86 build shows:
> >> >> >> >
> >> >> >> >
> >> >> >> > | configure: error: --enable-gallium-llvm selected but llvm-config is
> >> >> >> > not
> >> >> >> > found
> >> >> >> > | ERROR: Function failed: do_configure (log file is located at
> >> >> >> >
> >> >> >> > /home/jenkins/oe/world/shr-core/tmp-glibc/work/i586-oe-linux/mesa/2_17.0.1-r0/temp/log.do_configure.11359)
> >> >> >> >
> >> >> >>
> >> >> >> can you point where is llvm-config installed in sysroot ? its possible
> >> >> >> its not in native sysroot location ${STAGING_BINDIR_NATIVE}
> >> >> >
> >> >> > OE qemux86@ ~/build/oe-core $ find
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot* -name llvm\*
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/bin/crossscripts/llvm-config
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/bin/crossscripts/llvm-config3.3
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/include/llvm3.3
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/include/llvm3.3/llvm-c
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/include/llvm3.3/llvm
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/include/llvm3.3/llvm/Config/llvm-config.h
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/usr/lib/llvm3.3
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/sysroot-providers/llvm-common
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot/sysroot-providers/llvm3.3
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot-native/installeddeps/llvm3.3.complete
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot-native/installeddeps/llvm-common.complete
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot-native/installeddeps/llvm-common.6be6a4ae98ee0dff7c2a4c4df17f026a
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot-native/installeddeps/llvm-common
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot-native/installeddeps/llvm3.3.388adaa288ab3b1d35e01a43b6542368
> >> >> >
> >> >> > tmp-glibc/work/i586-oe-linux/mesa/2_17.0.2-r0/recipe-sysroot-native/installeddeps/llvm3.3
> >> >> >
> >> >>
> >> >> so it seems it should point to <recipe-sysroot>/usr/bin/crossscripts
> >> >> can you try changing -with-llvm-prefix to point to this dir ?
> >> >>
> >> >> >>
> >> >> >> >
> >> >> >> > I've noticed some llvm changes for meta-clang, do we need similar
> >> >> >> > changes
> >> >> >> > for meta-oe version of llvm?
> >> >> >> >
> >> >> >> >
> >> >> >> > On Sun, Mar 12, 2017 at 12:16 AM, Khem Raj <raj.khem@gmail.com>
> >> >> >> > wrote:
> >> >> >> >>
> >> >> >> >>
> >> >> >> >>
> >> >> >> >> On 3/11/17 1:30 PM, Khem Raj wrote:
> >> >> >> >> > The following changes since commit
> >> >> >> >> > a47e64d985a610535449730806651f5bfd75d9ec:
> >> >> >> >> >
> >> >> >> >> >   libcomps: add a recipe (2017-03-11 16:08:50 +0000)
> >> >> >> >> >
> >> >> >> >> > are available in the git repository at:
> >> >> >> >> >
> >> >> >> >> >   git://git.openembedded.org/openembedded-core-contrib kraj/pu
> >> >> >> >> >
> >> >> >> >> > http://cgit.openembedded.org/openembedded-core-contrib/log/?h=kraj/pu
> >> >> >> >> >
> >> >> >> >> > Khem Raj (1):
> >> >> >> >> >   mesa: Contain configure search for llvm
> >> >> >> >> >
> >> >> >> >>
> >> >> >> >> I added another fix for mesa-gl to remove one of obsolete
> >> >> >> >> packageconfigs
> >> >> >> >> and its on the same pull branch now.
> >> >> >> >>
> >> >> >> >> >  meta/recipes-graphics/mesa/mesa.inc | 2 +-
> >> >> >> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >> >> >> >
> >> >> >> >> --
> >> >> >> >> _______________________________________________
> >> >> >> >> Openembedded-core mailing list
> >> >> >> >> Openembedded-core@lists.openembedded.org
> >> >> >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >> >> >> >
> >> >> >> >
> >> >> >
> >> >> > --
> >> >> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >> >
> >> >
> >
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]