From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [kvm-unit-tests PATCH 1/5] arch/run: simplify copy-paste of the command line Date: Wed, 28 Jun 2017 22:08:53 +0200 Message-ID: <20170628200857.1718-2-rkrcmar@redhat.com> References: <20170628200857.1718-1-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Paolo Bonzini , Drew Jones , Laurent Vivier , Thomas Huth , David Hildenbrand To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbdF1UJM (ORCPT ); Wed, 28 Jun 2017 16:09:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B0C040F04 for ; Wed, 28 Jun 2017 20:09:11 +0000 (UTC) In-Reply-To: <20170628200857.1718-1-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: The major annoyance coming from errata was "-initrd `mktemp`" that had to be removed before running the copy-pasted command line. Move "-initrd ..." part at the end of the line and hide it behind "#" if the initird file is a temporary one. This patch also brings s390 to use the same code as other architectures and eliminates code duplication. Signed-off-by: Radim Krčmář --- Adding the arch/run command line might also be worth it (i.e. adding echo $0 $@ to arch/run). --- arm/run | 5 +---- powerpc/run | 5 +---- s390x/run | 2 -- scripts/arch-run.bash | 18 ++++++++++++++++-- x86/run | 5 +---- 5 files changed, 19 insertions(+), 16 deletions(-) diff --git a/arm/run b/arm/run index 1b1602c74970..8d8918a461dc 100755 --- a/arm/run +++ b/arm/run @@ -71,12 +71,9 @@ if $qemu $M -device '?' 2>&1 | grep pci-testdev > /dev/null; then pci_testdev="-device pci-testdev" fi -initrd_create - M+=",accel=$ACCEL" command="$qemu -nodefaults $M -cpu $processor $chr_testdev $pci_testdev" -command+=" -display none -serial stdio $INITRD -kernel" +command+=" -display none -serial stdio -kernel" command="$(timeout_cmd) $command" -echo $command "$@" run_qemu $command "$@" diff --git a/powerpc/run b/powerpc/run index 7ccf1a36ff49..3fd5a91aeffb 100755 --- a/powerpc/run +++ b/powerpc/run @@ -35,14 +35,11 @@ if ! $qemu -machine '?' 2>&1 | grep 'pseries' > /dev/null; then exit 2 fi -initrd_create - M='-machine pseries' M+=",accel=$ACCEL" command="$qemu -nodefaults $M -bios $FIRMWARE" -command+=" -display none -serial stdio $INITRD -kernel" +command+=" -display none -serial stdio -kernel" command="$(migration_cmd) $(timeout_cmd) $command" -echo $command "$@" # powerpc tests currently exit with rtas-poweroff, which exits with 0. # run_qemu treats that as a failure exit and returns 1, so we need diff --git a/s390x/run b/s390x/run index cf333de9ccce..89210f4fb6b6 100755 --- a/s390x/run +++ b/s390x/run @@ -34,10 +34,8 @@ M='-machine s390-ccw-virtio' M+=",accel=$ACCEL" command="$qemu -nodefaults -nographic $M" command+=" -chardev stdio,id=con0 -device sclpconsole,chardev=con0" -[ -f "$ENV" ] && command+=" -initrd $ENV" command+=" -kernel" command="$(timeout_cmd) $command" -echo $command "$@" # We return the exit code via stdout, not via the QEMU return code lines=$(run_qemu $command "$@") diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 7c6c79ad3a9d..8ad37e4ebf97 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -28,9 +28,14 @@ run_qemu () { local stdout errors ret sig + echo -n $@ + initrd_create && + echo -n " #" + echo " $INITRD" + # stdout to {stdout}, stderr to $errors and stderr exec {stdout}>&1 - errors=$("${@}" >(tee /dev/stderr) > /dev/fd/$stdout) + errors=$("${@}" $INITRD >(tee /dev/stderr) > /dev/fd/$stdout) ret=$? exec {stdout}>&- @@ -158,14 +163,20 @@ search_qemu_binary () initrd_create () { + local ret + env_add_errata + ret=$? + unset INITRD [ -f "$ENV" ] && INITRD="-initrd $ENV" + + return $ret } env_add_errata () { - local line errata + local line errata ret=1 if [ -f "$ENV" ] && grep -q '^ERRATA_' <(env); then for line in $(grep '^ERRATA_' "$ENV"); do @@ -183,7 +194,10 @@ env_add_errata () trap_exit_push 'rm -f $ENV; [ "$ENV_OLD" ] && export ENV="$ENV_OLD" || unset ENV; unset ENV_OLD' [ -f "$ENV_OLD" ] && grep -v '^ERRATA_' "$ENV_OLD" > $ENV grep '^ERRATA_' <(env) >> $ENV + ret=0 fi + + return $ret } env_generate_errata () diff --git a/x86/run b/x86/run index 88f5ff771140..a06a7c0f80c8 100755 --- a/x86/run +++ b/x86/run @@ -33,11 +33,8 @@ else pc_testdev="-device testdev,chardev=testlog -chardev file,id=testlog,path=msr.out" fi -initrd_create - command="${qemu} -nodefaults -enable-kvm $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev" -command+=" $INITRD -kernel" +command+=" -kernel" command="$(timeout_cmd) $command" -echo ${command} "$@" run_qemu ${command} "$@" -- 2.13.2