All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, lersek@redhat.com,
	den@openvz.org, mreitz@redhat.com, eblake@redhat.com,
	berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options
Date: Mon, 10 Jul 2017 15:30:38 +0200	[thread overview]
Message-ID: <20170710133038.GH5772@noname.redhat.com> (raw)
In-Reply-To: <136f3543-665b-a138-1ff0-f96e2aaca0b4@kamp.de>

Am 10.07.2017 um 15:24 hat Peter Lieven geschrieben:
> Am 10.07.2017 um 15:10 schrieb Kevin Wolf:
> >Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben:
> >>Signed-off-by: Peter Lieven <pl@kamp.de>
> >>---
> >>  qapi/block-core.json | 44 +++++++++++++++++++++++++++++++++++++++++++-
> >>  1 file changed, 43 insertions(+), 1 deletion(-)
> >How does this make sense as a runtime option? What would happen if the
> >image contains one compression format and I specify another one on the
> >command line or in blockdev-add?
> >
> >Shouldn't it just be a create-time option and when you run qemu, it uses
> >whatever format that image has?
> 
> I was asked to add it here. It is indeed only a create option and has
> no other effect.

But if it's only a create option, why is it added to blockdev-add?

Kevin

  parent reply	other threads:[~2017-07-10 13:30 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 10:57 [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension Peter Lieven
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 1/8] docs: add compress format extension to qcow2 spec Peter Lieven
2017-07-10 12:58   ` Kevin Wolf
2017-07-10 13:27     ` Peter Lieven
2017-07-10 13:50       ` Kevin Wolf
2017-07-10 14:31         ` Eric Blake
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options Peter Lieven
2017-07-10 13:10   ` Kevin Wolf
2017-07-10 13:24     ` Peter Lieven
2017-07-10 13:27       ` Daniel P. Berrange
2017-07-10 13:30       ` Kevin Wolf [this message]
2017-07-10 13:32         ` Peter Lieven
2017-07-13  8:45         ` Peter Lieven
2017-07-13  8:52           ` Kevin Wolf
2017-07-13  9:18             ` Daniel P. Berrange
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 3/8] block/qcow2: parse compress create options Peter Lieven
2017-07-10 13:52   ` Daniel P. Berrange
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 4/8] qemu-img: add documentation for compress settings Peter Lieven
2017-07-10 13:21   ` Kevin Wolf
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 5/8] block/qcow2: read and write the compress format extension Peter Lieven
2017-07-10 13:25   ` Kevin Wolf
2017-07-10 13:29     ` Peter Lieven
2017-07-10 13:34       ` Kevin Wolf
2017-07-10 13:44         ` Daniel P. Berrange
2017-07-10 13:46           ` Peter Lieven
2017-07-10 13:58             ` Daniel P. Berrange
2017-07-10 13:52           ` Kevin Wolf
2017-07-10 13:55             ` Daniel P. Berrange
2017-07-13  8:44               ` Peter Lieven
2017-07-13  9:21                 ` Daniel P. Berrange
2017-07-13 13:49                   ` Peter Lieven
2017-07-13 14:00                     ` Daniel P. Berrange
2017-07-13 14:03                       ` Peter Lieven
2017-07-13 14:07                         ` Daniel P. Berrange
2017-07-13 14:18                           ` Peter Lieven
2017-07-13 14:58                             ` Daniel P. Berrange
2017-07-13 15:00                               ` Peter Lieven
2017-07-13 15:01                                 ` Daniel P. Berrange
2017-07-13 15:02                                   ` Peter Lieven
2017-07-13 15:06                                     ` Daniel P. Berrange
2017-07-13 15:13                                       ` Peter Lieven
2017-07-13 15:17                                         ` Daniel P. Berrange
2017-07-13 15:21                                           ` Peter Lieven
2017-07-13 15:21                                         ` Eric Blake
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 6/8] block/qcow2: optimize qcow2_co_pwritev_compressed Peter Lieven
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 7/8] block/qcow2: start using the compress format extension Peter Lieven
2017-06-29 10:57 ` [Qemu-devel] [PATCH V2 8/8] block/qcow2: add lzo compress format Peter Lieven
2017-07-06 23:49 ` [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension no-reply
2017-07-07  0:02   ` Fam Zheng
2017-07-10 12:36 ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710133038.GH5772@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=berrange@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.