From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750930AbdGZF0m (ORCPT ); Wed, 26 Jul 2017 01:26:42 -0400 Received: from mga06.intel.com ([134.134.136.31]:48534 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdGZF0k (ORCPT ); Wed, 26 Jul 2017 01:26:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,413,1496127600"; d="scan'208";a="131972257" Date: Wed, 26 Jul 2017 10:59:31 +0530 From: Vinod Koul To: Pierre Yves MORDRET Cc: Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Russell King , Dan Williams , "M'boumba Cedric Madianga" , Fabrice GASNIER , Herbert Xu , Fabien DESSENNE , Amelie DELAUNAY , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Message-ID: <20170726052930.GF3053@localhost> References: <1499343623-5964-1-git-send-email-pierre-yves.mordret@st.com> <1499343623-5964-3-git-send-email-pierre-yves.mordret@st.com> <20170722065133.GT3053@localhost> <2b916330-9b65-f4d5-817f-79b66cc236b3@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b916330-9b65-f4d5-817f-79b66cc236b3@st.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2017 at 01:55:10PM +0000, Pierre Yves MORDRET wrote: > >> + > >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!res) > >> + return -ENODEV; > >> + > >> + iomem = devm_ioremap_resource(&pdev->dev, res); > >> + if (!iomem) > >> + return -ENOMEM; > >> + > >> + spin_lock_init(&stm32_dmamux->lock); > >> + > >> + stm32_dmamux->clk = devm_clk_get(&pdev->dev, NULL); > >> + if (IS_ERR(stm32_dmamux->clk)) { > >> + dev_info(&pdev->dev, "Missing controller clock\n"); > > > > Can you check for EPROBE_DEFER and print only for if that is not the error > > otherwise we end up sapmming with defered probe issues > > > > This is what you meant ? > if (IS_ERR(stm32_dmamux->clk) != EPROBE_DEFER) { > dev_info(&pdev->dev, "Missing controller clock\n"); > return PTR_ERR(stm32_dmamux->clk); > } > > OR > > if (IS_ERR(stm32_dmamux->clk)) { > if (IS_ERR(stm32_dmamux->clk) != EPROBE_DEFER) > dev_info(&pdev->dev, "Missing controller clock\n"); > return PTR_ERR(stm32_dmamux->clk); > } This one please > > >> + > >> +#ifndef __DMA_STM32_DMAMUX_H > >> +#define __DMA_STM32_DMAMUX_H > >> + > >> +#if defined(CONFIG_STM32_DMAMUX) > >> +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 chan_id); > > > > Why do we need a custom API in this case? > > > > This API is called by DMA when a slave is requested by client. DMA can work > without DMAMUX this API has been put in place to configure DMAMUX whether client > is requesting a DMAMUX Channel instead of a DMA one. You mean the dmaengine driver right? -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Date: Wed, 26 Jul 2017 10:59:31 +0530 Message-ID: <20170726052930.GF3053@localhost> References: <1499343623-5964-1-git-send-email-pierre-yves.mordret@st.com> <1499343623-5964-3-git-send-email-pierre-yves.mordret@st.com> <20170722065133.GT3053@localhost> <2b916330-9b65-f4d5-817f-79b66cc236b3@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2b916330-9b65-f4d5-817f-79b66cc236b3-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pierre Yves MORDRET Cc: Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Russell King , Dan Williams , M'boumba Cedric Madianga , Fabrice GASNIER , Herbert Xu , Fabien DESSENNE , Amelie DELAUNAY , "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, Jul 24, 2017 at 01:55:10PM +0000, Pierre Yves MORDRET wrote: > >> + > >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!res) > >> + return -ENODEV; > >> + > >> + iomem = devm_ioremap_resource(&pdev->dev, res); > >> + if (!iomem) > >> + return -ENOMEM; > >> + > >> + spin_lock_init(&stm32_dmamux->lock); > >> + > >> + stm32_dmamux->clk = devm_clk_get(&pdev->dev, NULL); > >> + if (IS_ERR(stm32_dmamux->clk)) { > >> + dev_info(&pdev->dev, "Missing controller clock\n"); > > > > Can you check for EPROBE_DEFER and print only for if that is not the error > > otherwise we end up sapmming with defered probe issues > > > > This is what you meant ? > if (IS_ERR(stm32_dmamux->clk) != EPROBE_DEFER) { > dev_info(&pdev->dev, "Missing controller clock\n"); > return PTR_ERR(stm32_dmamux->clk); > } > > OR > > if (IS_ERR(stm32_dmamux->clk)) { > if (IS_ERR(stm32_dmamux->clk) != EPROBE_DEFER) > dev_info(&pdev->dev, "Missing controller clock\n"); > return PTR_ERR(stm32_dmamux->clk); > } This one please > > >> + > >> +#ifndef __DMA_STM32_DMAMUX_H > >> +#define __DMA_STM32_DMAMUX_H > >> + > >> +#if defined(CONFIG_STM32_DMAMUX) > >> +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 chan_id); > > > > Why do we need a custom API in this case? > > > > This API is called by DMA when a slave is requested by client. DMA can work > without DMAMUX this API has been put in place to configure DMAMUX whether client > is requesting a DMAMUX Channel instead of a DMA one. You mean the dmaengine driver right? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Wed, 26 Jul 2017 10:59:31 +0530 Subject: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver In-Reply-To: <2b916330-9b65-f4d5-817f-79b66cc236b3@st.com> References: <1499343623-5964-1-git-send-email-pierre-yves.mordret@st.com> <1499343623-5964-3-git-send-email-pierre-yves.mordret@st.com> <20170722065133.GT3053@localhost> <2b916330-9b65-f4d5-817f-79b66cc236b3@st.com> Message-ID: <20170726052930.GF3053@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 24, 2017 at 01:55:10PM +0000, Pierre Yves MORDRET wrote: > >> + > >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!res) > >> + return -ENODEV; > >> + > >> + iomem = devm_ioremap_resource(&pdev->dev, res); > >> + if (!iomem) > >> + return -ENOMEM; > >> + > >> + spin_lock_init(&stm32_dmamux->lock); > >> + > >> + stm32_dmamux->clk = devm_clk_get(&pdev->dev, NULL); > >> + if (IS_ERR(stm32_dmamux->clk)) { > >> + dev_info(&pdev->dev, "Missing controller clock\n"); > > > > Can you check for EPROBE_DEFER and print only for if that is not the error > > otherwise we end up sapmming with defered probe issues > > > > This is what you meant ? > if (IS_ERR(stm32_dmamux->clk) != EPROBE_DEFER) { > dev_info(&pdev->dev, "Missing controller clock\n"); > return PTR_ERR(stm32_dmamux->clk); > } > > OR > > if (IS_ERR(stm32_dmamux->clk)) { > if (IS_ERR(stm32_dmamux->clk) != EPROBE_DEFER) > dev_info(&pdev->dev, "Missing controller clock\n"); > return PTR_ERR(stm32_dmamux->clk); > } This one please > > >> + > >> +#ifndef __DMA_STM32_DMAMUX_H > >> +#define __DMA_STM32_DMAMUX_H > >> + > >> +#if defined(CONFIG_STM32_DMAMUX) > >> +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 chan_id); > > > > Why do we need a custom API in this case? > > > > This API is called by DMA when a slave is requested by client. DMA can work > without DMAMUX this API has been put in place to configure DMAMUX whether client > is requesting a DMAMUX Channel instead of a DMA one. You mean the dmaengine driver right? -- ~Vinod