All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Kiran Gunda <kgunda@codeaurora.org>,
	gregkh@linuxfoundation.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
	David Collins <collinsd@codeaurora.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally
Date: Tue, 22 Aug 2017 17:01:40 +0800	[thread overview]
Message-ID: <20170822090139.GC3685@dragon> (raw)
In-Reply-To: <e0af96c3-208b-abfc-8b2a-4ea1cc810ec7@codeaurora.org>

On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote:
> On 08/18/2017 08:28 AM, Kiran Gunda wrote:
> > The peripheral ownership check is not necessary on single master
> > platforms. Hence, enforce the peripheral ownership check optionally.
> >
> > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> > Tested-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> 
> This sounds like a band-aid. Isn't the gpio driver going to keep probing
> all the pins that are not supposed to be accessed due to security
> constraints? What exactly is failing in the gpio case?
> 
> Also, I thought we were getting rid of the ownership checks? Or at
> least, putting them behind some debug kernel feature check or something?

I'm wondering that too.  Since we have the following patch to remove the
check on read/write access anyway, why are we adding the check in .xlate
hook?

spmi: pmic-arb: remove the read/write access checks

Shawn

  parent reply	other threads:[~2017-08-22  9:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 15:28 [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Kiran Gunda
     [not found] ` <1503070110-15018-1-git-send-email-kgunda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-08-21 23:18   ` Stephen Boyd
2017-08-21 23:18     ` Stephen Boyd
2017-08-22  8:55     ` Shawn Guo
2017-08-22 20:31       ` Stephen Boyd
2017-08-22 20:31         ` Stephen Boyd
2017-08-23 12:57         ` kgunda
2017-08-24 12:18         ` Shawn Guo
2017-08-24 18:37           ` Stephen Boyd
2017-08-24 18:37             ` Stephen Boyd
2017-08-25  7:47             ` Shawn Guo
2017-08-25 23:18               ` Stephen Boyd
2017-08-25 23:18                 ` Stephen Boyd
     [not found]                 ` <20170825231818.GP21656-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-08-26  3:46                   ` Shawn Guo
2017-08-26  3:46                     ` Shawn Guo
2017-08-30 21:02                     ` Stephen Boyd
2017-08-30 21:02                       ` Stephen Boyd
2017-08-31  8:37                       ` Shawn Guo
2017-09-01  1:30                         ` Stephen Boyd
     [not found]                           ` <20170901013048.GK21656-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-09-01  3:00                             ` Shawn Guo
2017-09-01  3:00                               ` Shawn Guo
2017-08-28  8:27       ` Fenglin Wu
     [not found]         ` <93b8935e-061f-ba3a-ee36-8ffbc8230bcc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-08-28 14:47           ` Shawn Guo
2017-08-28 14:47             ` Shawn Guo
2017-08-22  9:01     ` Shawn Guo [this message]
2017-08-28 11:53 ` Greg KH
2017-08-28 14:08   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822090139.GC3685@dragon \
    --to=shawnguo@kernel.org \
    --cc=adharmap@codeaurora.org \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kgunda@codeaurora.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.