From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2 REPOST 09/12] x86/hvm/ioreq: simplify
 code and use consistent naming
Date: Thu, 24 Aug 2017 18:02:31 +0100
Message-ID: <20170824170231.teui3x7466xovmxt@dhcp-3-128.uk.xensource.com>
References: <20170822145107.6877-1-paul.durrant@citrix.com>
 <20170822145107.6877-10-paul.durrant@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=402c228e5=roger.pau@citrix.com>)
 id 1dkvWg-0003pd-1d
 for xen-devel@lists.xenproject.org; Thu, 24 Aug 2017 17:02:38 +0000
Content-Disposition: inline
In-Reply-To: <20170822145107.6877-10-paul.durrant@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

T24gVHVlLCBBdWcgMjIsIDIwMTcgYXQgMDM6NTE6MDNQTSArMDEwMCwgUGF1bCBEdXJyYW50IHdy
b3RlOgo+IFRoaXMgcGF0Y2ggcmUtd29ya3MgbXVjaCBvZiB0aGUgSU9SRVEgc2VydmVyIGluaXRp
YWxpemF0aW9uIGFuZCB0ZWFyZG93bgo+IGNvZGU6Cj4gCj4gLSBUaGUgaHZtX21hcC91bm1hcF9p
b3JlcV9nZm4oKSBmdW5jdGlvbnMgYXJlIGV4cGFuZGVkIHRvIGNhbGwgdGhyb3VnaAo+ICAgdG8g
aHZtX2FsbG9jL2ZyZWVfaW9yZXFfZ2ZuKCkgcmF0aGVyIHRoYW4gZXhwZWN0aW5nIHRoZW0gdG8g
YmUgY2FsbGVkCj4gICBzZXBhcmF0ZWx5IGJ5IG91dGVyIGZ1bmN0aW9ucy4KPiAtIFNldmVyYWwg
ZnVuY3Rpb25zIG5vdyB0ZXN0IHRoZSB2YWxpZGl0eSBvZiB0aGUgaHZtX2lvcmVxX3BhZ2UgZ2Zu
IHZhbHVlCj4gICB0byBkZXRlcm1pbmUgd2hldGhlciB0aGV5IG5lZWQgdG8gYWN0LiBUaGlzIG1l
YW5zIGNhbiBiZSBzYWZlbHkgY2FsbGVkCj4gICBmb3IgdGhlIGJ1ZmlvcmVxIHBhZ2UgZXZlbiB3
aGVuIGl0IGlzIG5vdCB1c2VkLgo+IC0gaHZtX2FkZC9yZW1vdmVfaW9yZXFfZ2ZuKCkgc2ltcGx5
IHJldHVybiBpbiB0aGUgY2FzZSBvZiB0aGUgZGVmYXVsdAo+ICAgSU9SRVEgc2VydmVyIHNvIGNh
bGxlcnMgbm8gbG9uZ2VyIG5lZWQgdG8gdGVzdCBiZWZvcmUgY2FsbGluZy4KPiAtIGh2bV9pb3Jl
cV9zZXJ2ZXJfc2V0dXBfcGFnZXMoKSBpcyByZW5hbWVkIHRvIGh2bV9pb3JlcV9zZXJ2ZXJfbWFw
X3BhZ2VzKCkKPiAgIHRvIG1pcnJvciB0aGUgZXhpc3RpbmcgaHZtX2lvcmVxX3NlcnZlcl91bm1h
cF9wYWdlcygpLgo+IAo+IEFsbCBvZiB0aGlzIHNpZ25pZmljYW50bHkgc2hvcnRlbnMgdGhlIGNv
ZGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4
LmNvbT4KPiAtLS0KPiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IENjOiBB
bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+IC0tLQo+ICB4ZW4vYXJj
aC94ODYvaHZtL2lvcmVxLmMgfCAxODEgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDY5IGluc2VydGlvbnMoKyksIDExMiBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9pb3JlcS5jIGIv
eGVuL2FyY2gveDg2L2h2bS9pb3JlcS5jCj4gaW5kZXggNTczNzA4MjIzOC4uZWRmYjM5NGM1OSAx
MDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL2lvcmVxLmMKPiArKysgYi94ZW4vYXJjaC94
ODYvaHZtL2lvcmVxLmMKPiBAQCAtMTgxLDYzICsxODEsNzYgQEAgYm9vbCBoYW5kbGVfaHZtX2lv
X2NvbXBsZXRpb24oc3RydWN0IHZjcHUgKnYpCj4gICAgICByZXR1cm4gdHJ1ZTsKPiAgfQo+ICAK
PiAtc3RhdGljIGludCBodm1fYWxsb2NfaW9yZXFfZ2ZuKHN0cnVjdCBkb21haW4gKmQsIHVuc2ln
bmVkIGxvbmcgKmdmbikKPiArc3RhdGljIHVuc2lnbmVkIGxvbmcgaHZtX2FsbG9jX2lvcmVxX2dm
bihzdHJ1Y3QgaHZtX2lvcmVxX3NlcnZlciAqcykKCmdmbl90IGFzIHRoZSByZXR1cm4gdHlwZSBp
bnN0ZWFkPyBJIHNlZSB0aGF0IHlvdSBhcmUgbW92aW5nIGl0LCBzbyBJCndvbid0IGluc2lzdCAo
SSBhc3N1bWUgdGhlcmUncyBhbHNvIHNvbWUgb3RoZXIgcmVmYWN0b3JpbmcgaW52b2x2ZWQgaW4K
bWFraW5nIHRoaXMgcmV0dXJuIGdmbl90KS4gSSBzZWUgdGhlcmUgYXJlIGFsc28gZnVydGhlciB1
c2VzIG9mCnVuc2lnbmVkIGxvbmcgdG8gc3RvcmUgZ2ZucywgSSdtIG5vdCBnb2luZyB0byBwb2lu
dCB0aG9zZSBvdXQuCgo+ICB7Cj4gKyAgICBzdHJ1Y3QgZG9tYWluICpkID0gcy0+ZG9tYWluOwo+
ICAgICAgdW5zaWduZWQgaW50IGk7Cj4gLSAgICBpbnQgcmM7Cj4gIAo+IC0gICAgcmMgPSAtRU5P
TUVNOwo+ICsgICAgQVNTRVJUKCFzLT5pc19kZWZhdWx0KTsKPiArCj4gICAgICBmb3IgKCBpID0g
MDsgaSA8IHNpemVvZihkLT5hcmNoLmh2bV9kb21haW4uaW9yZXFfZ2ZuLm1hc2spICogODsgaSsr
ICkKPiAgICAgIHsKPiAgICAgICAgICBpZiAoIHRlc3RfYW5kX2NsZWFyX2JpdChpLCAmZC0+YXJj
aC5odm1fZG9tYWluLmlvcmVxX2dmbi5tYXNrKSApCj4gICAgICAgICAgewoKVGhlIGJyYWNlcyBh
cmUgbm90IHN0cmljdGx5IG5lZWRlZCBhbnltb3JlLCBidXQgdGhhdCdzIGEgcXVlc3Rpb24gb2YK
dGFzdGUuCgo+IC0gICAgICAgICAgICAqZ2ZuID0gZC0+YXJjaC5odm1fZG9tYWluLmlvcmVxX2dm
bi5iYXNlICsgaTsKPiAtICAgICAgICAgICAgcmMgPSAwOwo+IC0gICAgICAgICAgICBicmVhazsK
PiArICAgICAgICAgICAgcmV0dXJuIGQtPmFyY2guaHZtX2RvbWFpbi5pb3JlcV9nZm4uYmFzZSAr
IGk7Cj4gICAgICAgICAgfQo+ICAgICAgfQo+ICAKPiAtICAgIHJldHVybiByYzsKPiArICAgIHJl
dHVybiBnZm5feChJTlZBTElEX0dGTik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGh2bV9mcmVl
X2lvcmVxX2dmbihzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGdmbikKPiArc3RhdGlj
IHZvaWQgaHZtX2ZyZWVfaW9yZXFfZ2ZuKHN0cnVjdCBodm1faW9yZXFfc2VydmVyICpzLAo+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBnZm4pCj4gIHsKPiAr
ICAgIHN0cnVjdCBkb21haW4gKmQgPSBzLT5kb21haW47Cj4gICAgICB1bnNpZ25lZCBpbnQgaSA9
IGdmbiAtIGQtPmFyY2guaHZtX2RvbWFpbi5pb3JlcV9nZm4uYmFzZTsKPiAgCj4gLSAgICBpZiAo
IGdmbiAhPSBnZm5feChJTlZBTElEX0dGTikgKQo+IC0gICAgICAgIHNldF9iaXQoaSwgJmQtPmFy
Y2guaHZtX2RvbWFpbi5pb3JlcV9nZm4ubWFzayk7Cj4gKyAgICBBU1NFUlQoIXMtPmlzX2RlZmF1
bHQpOwoKSSB3b3VsZCBtYXliZSBhZGQgYSBnZm4gIT0gZ2ZuX3goSU5WQUxJRF9HRk4pIGluIHRo
ZSBBU1NFUlQuCgo+ICsKPiArICAgIHNldF9iaXQoaSwgJmQtPmFyY2guaHZtX2RvbWFpbi5pb3Jl
cV9nZm4ubWFzayk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGh2bV91bm1hcF9pb3JlcV9wYWdl
KHN0cnVjdCBodm1faW9yZXFfc2VydmVyICpzLCBib29sIGJ1ZikKPiArc3RhdGljIHZvaWQgaHZt
X3VubWFwX2lvcmVxX2dmbihzdHJ1Y3QgaHZtX2lvcmVxX3NlcnZlciAqcywgYm9vbCBidWYpCgpJ
J20gbm90IHN1cmUgaWYgeW91IG5lZWQgdGhlIGJ1ZiBwYXJhbWV0ZXIsIGl0IHNlZW1zIGluIGFs
bCBjYXNlcyB5b3UKd2FudCB0byB1bm1hcCBldmVyeXRoaW5nIHdoZW4gY2FsbGluZyBodm1fdW5t
YXBfaW9yZXFfZ2ZuPyAoc2FtZQphcHBsaWVzIHRvIGh2bV9yZW1vdmVfaW9yZXFfZ2ZuIGFuZCBo
dm1fYWRkX2lvcmVxX2dmbikKCj4gIHN0YXRpYyBpbnQgaHZtX2lvcmVxX3NlcnZlcl9tYXBfcGFn
ZXMoc3RydWN0IGh2bV9pb3JlcV9zZXJ2ZXIgKnMsCj4gLSAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBpb3JlcV9nZm4sCj4gLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBidWZpb3JlcV9nZm4pCj4gLXsK
PiAtICAgIGludCByYzsKPiAtCj4gLSAgICByYyA9IGh2bV9tYXBfaW9yZXFfcGFnZShzLCBmYWxz
ZSwgaW9yZXFfZ2ZuKTsKPiAtICAgIGlmICggcmMgKQo+IC0gICAgICAgIHJldHVybiByYzsKPiAt
Cj4gLSAgICBpZiAoIGJ1ZmlvcmVxX2dmbiAhPSBnZm5feChJTlZBTElEX0dGTikgKQo+IC0gICAg
ICAgIHJjID0gaHZtX21hcF9pb3JlcV9wYWdlKHMsIHRydWUsIGJ1ZmlvcmVxX2dmbik7Cj4gLQo+
IC0gICAgaWYgKCByYyApCj4gLSAgICAgICAgaHZtX3VubWFwX2lvcmVxX3BhZ2UocywgZmFsc2Up
Owo+IC0KPiAtICAgIHJldHVybiByYzsKPiAtfQo+IC0KPiAtc3RhdGljIGludCBodm1faW9yZXFf
c2VydmVyX3NldHVwX3BhZ2VzKHN0cnVjdCBodm1faW9yZXFfc2VydmVyICpzLAo+IC0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBoYW5kbGVfYnVmaW9yZXEpCj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBoYW5kbGVfYnVmaW9y
ZXEpCj4gIHsKPiAtICAgIHN0cnVjdCBkb21haW4gKmQgPSBzLT5kb21haW47Cj4gLSAgICB1bnNp
Z25lZCBsb25nIGlvcmVxX2dmbiA9IGdmbl94KElOVkFMSURfR0ZOKTsKPiAtICAgIHVuc2lnbmVk
IGxvbmcgYnVmaW9yZXFfZ2ZuID0gZ2ZuX3goSU5WQUxJRF9HRk4pOwo+IC0gICAgaW50IHJjOwo+
IC0KPiAtICAgIGlmICggcy0+aXNfZGVmYXVsdCApCj4gLSAgICB7Cj4gLSAgICAgICAgLyoKPiAt
ICAgICAgICAgKiBUaGUgZGVmYXVsdCBpb3JlcSBzZXJ2ZXIgbXVzdCBoYW5kbGUgYnVmZmVyZWQg
aW9yZXFzLCBmb3IKPiAtICAgICAgICAgKiBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eS4KPiAtICAg
ICAgICAgKi8KPiAtICAgICAgICBBU1NFUlQoaGFuZGxlX2J1ZmlvcmVxKTsKPiAtICAgICAgICBy
ZXR1cm4gaHZtX2lvcmVxX3NlcnZlcl9tYXBfcGFnZXMocywKPiAtICAgICAgICAgICAgICAgICAg
IGQtPmFyY2guaHZtX2RvbWFpbi5wYXJhbXNbSFZNX1BBUkFNX0lPUkVRX1BGTl0sCj4gLSAgICAg
ICAgICAgICAgICAgICBkLT5hcmNoLmh2bV9kb21haW4ucGFyYW1zW0hWTV9QQVJBTV9CVUZJT1JF
UV9QRk5dKTsKPiAtICAgIH0KPiArICAgIGludCByYyA9IC1FTk9NRU07CgpObyBuZWVkIHRvIHNl
dCByYywgeW91IGFyZSBqdXN0IG92ZXJ3cml0aW5nIGl0IGluIHRoZSBuZXh0IGxpbmUuCgpSb2dl
ci4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k
ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54
ZW4ub3JnL3hlbi1kZXZlbAo=