From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197])
	by kanga.kvack.org (Postfix) with ESMTP id 7F8CA6810C8
	for <linux-mm@kvack.org>; Fri, 25 Aug 2017 16:49:18 -0400 (EDT)
Received: by mail-wr0-f197.google.com with SMTP id w14so1220538wrc.5
        for <linux-mm@kvack.org>; Fri, 25 Aug 2017 13:49:18 -0700 (PDT)
Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12])
        by mx.google.com with ESMTPS id u83si1876039wmb.57.2017.08.25.13.49.16
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Fri, 25 Aug 2017 13:49:17 -0700 (PDT)
Date: Fri, 25 Aug 2017 13:49:14 -0700
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Intel-gfx] [PATCH 01/23] mm/shmem: introduce
 shmem_file_setup_with_mnt
Message-Id: <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org>
In-Reply-To: <CAM0jSHMiOKGEEsuxUuX5ayD_eAVByQZaCsE8rs8_XPopxnbcfg@mail.gmail.com>
References: <20170821183503.12246-1-matthew.auld@intel.com>
	<20170821183503.12246-2-matthew.auld@intel.com>
	<1503480688.6276.4.camel@linux.intel.com>
	<20170823153456.b3c50e1ec109fd69f672b348@linux-foundation.org>
	<CAM0jSHMiOKGEEsuxUuX5ayD_eAVByQZaCsE8rs8_XPopxnbcfg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, linux-mm@kvack.org, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Hugh Dickins <hughd@google.com>, Dave Hansen <dave.hansen@intel.com>, Matthew Auld <matthew.auld@intel.com>, "Kirill A . Shutemov" <kirill@shutemov.name>

On Thu, 24 Aug 2017 13:04:09 +0100 Matthew Auld <matthew.william.auld@gmail.com> wrote:

> On 23 August 2017 at 23:34, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Wed, 23 Aug 2017 12:31:28 +0300 Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> >
> >> This patch has been floating around for a while now Acked and without
> >> further comments. It is blocking us from merging huge page support to
> >> drm/i915.
> >>
> >> Would you mind merging it, or prodding the right people to get it in?
> >>
> >> Regards, Joonas
> >>
> >> On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote:
> >> > We are planning to use our own tmpfs mnt in i915 in place of the
> >> > shm_mnt, such that we can control the mount options, in particular
> >> > huge=, which we require to support huge-gtt-pages. So rather than roll
> >> > our own version of __shmem_file_setup, it would be preferred if we could
> >> > just give shmem our mnt, and let it do the rest.
> >
> > hm, it's a bit odd.  I'm having trouble locating the code which handles
> > huge=within_size (and any other options?).
> 
> See here https://patchwork.freedesktop.org/patch/172771/, currently we
> only care about huge=within_size.
> 
> > What other approaches were considered?
> 
> We also tried https://patchwork.freedesktop.org/patch/156528/, where
> it was suggested that we mount our own tmpfs instance.
> 
> Following from that we now have our own tmps mnt mounted with
> huge=within_size. With this patch we avoid having to roll our own
> __shmem_file_setup like in
> https://patchwork.freedesktop.org/patch/163024/.
> 
> > Was it not feasible to add i915-specific mount options to
> > mm/shmem.c (for example?).
> 
> Hmm, I think within_size should suffice for our needs.

hm, ok, well, unless someone can think of something cleaner, please add
my ack and include it in the appropriate drm tree.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 01/23] mm/shmem: introduce
 shmem_file_setup_with_mnt
Date: Fri, 25 Aug 2017 13:49:14 -0700
Message-ID: <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org>
References: <20170821183503.12246-1-matthew.auld@intel.com>
 <20170821183503.12246-2-matthew.auld@intel.com>
 <1503480688.6276.4.camel@linux.intel.com>
 <20170823153456.b3c50e1ec109fd69f672b348@linux-foundation.org>
 <CAM0jSHMiOKGEEsuxUuX5ayD_eAVByQZaCsE8rs8_XPopxnbcfg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.linuxfoundation.org (mail.linuxfoundation.org
 [140.211.169.12])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C7B1789CCB
 for <intel-gfx@lists.freedesktop.org>; Fri, 25 Aug 2017 20:49:16 +0000 (UTC)
In-Reply-To: <CAM0jSHMiOKGEEsuxUuX5ayD_eAVByQZaCsE8rs8_XPopxnbcfg@mail.gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Dave Hansen <dave.hansen@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Hugh Dickins <hughd@google.com>, linux-mm@kvack.org, Matthew Auld <matthew.auld@intel.com>, "Kirill A . Shutemov" <kirill@shutemov.name>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyNCBBdWcgMjAxNyAxMzowNDowOSArMDEwMCBNYXR0aGV3IEF1bGQgPG1hdHRoZXcu
d2lsbGlhbS5hdWxkQGdtYWlsLmNvbT4gd3JvdGU6Cgo+IE9uIDIzIEF1Z3VzdCAyMDE3IGF0IDIz
OjM0LCBBbmRyZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPiB3cm90ZToKPiA+
IE9uIFdlZCwgMjMgQXVnIDIwMTcgMTI6MzE6MjggKzAzMDAgSm9vbmFzIExhaHRpbmVuIDxqb29u
YXMubGFodGluZW5AbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPj4gVGhpcyBwYXRjaCBo
YXMgYmVlbiBmbG9hdGluZyBhcm91bmQgZm9yIGEgd2hpbGUgbm93IEFja2VkIGFuZCB3aXRob3V0
Cj4gPj4gZnVydGhlciBjb21tZW50cy4gSXQgaXMgYmxvY2tpbmcgdXMgZnJvbSBtZXJnaW5nIGh1
Z2UgcGFnZSBzdXBwb3J0IHRvCj4gPj4gZHJtL2k5MTUuCj4gPj4KPiA+PiBXb3VsZCB5b3UgbWlu
ZCBtZXJnaW5nIGl0LCBvciBwcm9kZGluZyB0aGUgcmlnaHQgcGVvcGxlIHRvIGdldCBpdCBpbj8K
PiA+Pgo+ID4+IFJlZ2FyZHMsIEpvb25hcwo+ID4+Cj4gPj4gT24gTW9uLCAyMDE3LTA4LTIxIGF0
IDE5OjM0ICswMTAwLCBNYXR0aGV3IEF1bGQgd3JvdGU6Cj4gPj4gPiBXZSBhcmUgcGxhbm5pbmcg
dG8gdXNlIG91ciBvd24gdG1wZnMgbW50IGluIGk5MTUgaW4gcGxhY2Ugb2YgdGhlCj4gPj4gPiBz
aG1fbW50LCBzdWNoIHRoYXQgd2UgY2FuIGNvbnRyb2wgdGhlIG1vdW50IG9wdGlvbnMsIGluIHBh
cnRpY3VsYXIKPiA+PiA+IGh1Z2U9LCB3aGljaCB3ZSByZXF1aXJlIHRvIHN1cHBvcnQgaHVnZS1n
dHQtcGFnZXMuIFNvIHJhdGhlciB0aGFuIHJvbGwKPiA+PiA+IG91ciBvd24gdmVyc2lvbiBvZiBf
X3NobWVtX2ZpbGVfc2V0dXAsIGl0IHdvdWxkIGJlIHByZWZlcnJlZCBpZiB3ZSBjb3VsZAo+ID4+
ID4ganVzdCBnaXZlIHNobWVtIG91ciBtbnQsIGFuZCBsZXQgaXQgZG8gdGhlIHJlc3QuCj4gPgo+
ID4gaG0sIGl0J3MgYSBiaXQgb2RkLiAgSSdtIGhhdmluZyB0cm91YmxlIGxvY2F0aW5nIHRoZSBj
b2RlIHdoaWNoIGhhbmRsZXMKPiA+IGh1Z2U9d2l0aGluX3NpemUgKGFuZCBhbnkgb3RoZXIgb3B0
aW9ucz8pLgo+IAo+IFNlZSBoZXJlIGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9w
YXRjaC8xNzI3NzEvLCBjdXJyZW50bHkgd2UKPiBvbmx5IGNhcmUgYWJvdXQgaHVnZT13aXRoaW5f
c2l6ZS4KPiAKPiA+IFdoYXQgb3RoZXIgYXBwcm9hY2hlcyB3ZXJlIGNvbnNpZGVyZWQ/Cj4gCj4g
V2UgYWxzbyB0cmllZCBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMTU2
NTI4Lywgd2hlcmUKPiBpdCB3YXMgc3VnZ2VzdGVkIHRoYXQgd2UgbW91bnQgb3VyIG93biB0bXBm
cyBpbnN0YW5jZS4KPiAKPiBGb2xsb3dpbmcgZnJvbSB0aGF0IHdlIG5vdyBoYXZlIG91ciBvd24g
dG1wcyBtbnQgbW91bnRlZCB3aXRoCj4gaHVnZT13aXRoaW5fc2l6ZS4gV2l0aCB0aGlzIHBhdGNo
IHdlIGF2b2lkIGhhdmluZyB0byByb2xsIG91ciBvd24KPiBfX3NobWVtX2ZpbGVfc2V0dXAgbGlr
ZSBpbgo+IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8xNjMwMjQvLgo+
IAo+ID4gV2FzIGl0IG5vdCBmZWFzaWJsZSB0byBhZGQgaTkxNS1zcGVjaWZpYyBtb3VudCBvcHRp
b25zIHRvCj4gPiBtbS9zaG1lbS5jIChmb3IgZXhhbXBsZT8pLgo+IAo+IEhtbSwgSSB0aGluayB3
aXRoaW5fc2l6ZSBzaG91bGQgc3VmZmljZSBmb3Igb3VyIG5lZWRzLgoKaG0sIG9rLCB3ZWxsLCB1
bmxlc3Mgc29tZW9uZSBjYW4gdGhpbmsgb2Ygc29tZXRoaW5nIGNsZWFuZXIsIHBsZWFzZSBhZGQK
bXkgYWNrIGFuZCBpbmNsdWRlIGl0IGluIHRoZSBhcHByb3ByaWF0ZSBkcm0gdHJlZS4KCl9fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls
aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy
ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=