From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbdH1IcC (ORCPT ); Mon, 28 Aug 2017 04:32:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:35320 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752531AbdH1IcA (ORCPT ); Mon, 28 Aug 2017 04:32:00 -0400 Date: Mon, 28 Aug 2017 10:31:57 +0200 From: Michal Hocko To: Stephen Rothwell Cc: Randy Dunlap , akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, broonie@kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse Subject: Re: mmotm 2017-08-25-15-50 uploaded Message-ID: <20170828083157.GE17097@dhcp22.suse.cz> References: <59a0a9d1.jzOblYrHfdIDuDZw%akpm@linux-foundation.org> <3c9df006-0cc5-3a32-b715-1fbb43cb9ea8@infradead.org> <20170828075931.GC17097@dhcp22.suse.cz> <20170828182705.150afe66@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828182705.150afe66@canb.auug.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 28-08-17 18:27:05, Stephen Rothwell wrote: > Hi Michal, > > On Mon, 28 Aug 2017 09:59:31 +0200 Michal Hocko wrote: > > > > From 31d551dbcb1b7987a4cd07767c1e2805849b7a26 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Mon, 28 Aug 2017 09:41:39 +0200 > > Subject: [PATCH] > > mm-hmm-struct-hmm-is-only-use-by-hmm-mirror-functionality-v2-fix > > > > Compiler is complaining for allnoconfig > > > > kernel/fork.c: In function 'mm_init': > > kernel/fork.c:814:2: error: implicit declaration of function 'hmm_mm_init' [-Werror=implicit-function-declaration] > > hmm_mm_init(mm); > > ^ > > kernel/fork.c: In function '__mmdrop': > > kernel/fork.c:893:2: error: implicit declaration of function 'hmm_mm_destroy' [-Werror=implicit-function-declaration] > > hmm_mm_destroy(mm); > > > > Make sure that hmm_mm_init/hmm_mm_destroy empty stups are defined when > > CONFIG_HMM is disabled. > > > > Signed-off-by: Michal Hocko > > --- > > include/linux/hmm.h | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > > index 9583d9a15f9c..aeb94e682dda 100644 > > --- a/include/linux/hmm.h > > +++ b/include/linux/hmm.h > > @@ -508,11 +508,10 @@ static inline void hmm_mm_init(struct mm_struct *mm) > > { > > mm->hmm = NULL; > > } > > -#else /* IS_ENABLED(CONFIG_HMM_MIRROR) */ > > +#endif > > + > > +#else /* IS_ENABLED(CONFIG_HMM) */ > > static inline void hmm_mm_destroy(struct mm_struct *mm) {} > > static inline void hmm_mm_init(struct mm_struct *mm) {} > > -#endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */ > > - > > - > > #endif /* IS_ENABLED(CONFIG_HMM) */ > > #endif /* LINUX_HMM_H */ > > What happens when CONFIG_HMM is defined but CONFIG_HMM_MIRROR is not? > Or is that not possible (in which case why would we have > CONFIG_HMM_MIRROR)? This is something to Jerome to answer but hmm_mm_init/hmm_mm_destroy are used regardless of the specific HMM configuration so an empty stub should be defined unconditionally AFAIU. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 28 Aug 2017 10:31:57 +0200 From: Michal Hocko To: Stephen Rothwell Cc: Randy Dunlap , akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, broonie@kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse Subject: Re: mmotm 2017-08-25-15-50 uploaded Message-ID: <20170828083157.GE17097@dhcp22.suse.cz> References: <59a0a9d1.jzOblYrHfdIDuDZw%akpm@linux-foundation.org> <3c9df006-0cc5-3a32-b715-1fbb43cb9ea8@infradead.org> <20170828075931.GC17097@dhcp22.suse.cz> <20170828182705.150afe66@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828182705.150afe66@canb.auug.org.au> Sender: owner-linux-mm@kvack.org List-ID: On Mon 28-08-17 18:27:05, Stephen Rothwell wrote: > Hi Michal, > > On Mon, 28 Aug 2017 09:59:31 +0200 Michal Hocko wrote: > > > > From 31d551dbcb1b7987a4cd07767c1e2805849b7a26 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Mon, 28 Aug 2017 09:41:39 +0200 > > Subject: [PATCH] > > mm-hmm-struct-hmm-is-only-use-by-hmm-mirror-functionality-v2-fix > > > > Compiler is complaining for allnoconfig > > > > kernel/fork.c: In function 'mm_init': > > kernel/fork.c:814:2: error: implicit declaration of function 'hmm_mm_init' [-Werror=implicit-function-declaration] > > hmm_mm_init(mm); > > ^ > > kernel/fork.c: In function '__mmdrop': > > kernel/fork.c:893:2: error: implicit declaration of function 'hmm_mm_destroy' [-Werror=implicit-function-declaration] > > hmm_mm_destroy(mm); > > > > Make sure that hmm_mm_init/hmm_mm_destroy empty stups are defined when > > CONFIG_HMM is disabled. > > > > Signed-off-by: Michal Hocko > > --- > > include/linux/hmm.h | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > > index 9583d9a15f9c..aeb94e682dda 100644 > > --- a/include/linux/hmm.h > > +++ b/include/linux/hmm.h > > @@ -508,11 +508,10 @@ static inline void hmm_mm_init(struct mm_struct *mm) > > { > > mm->hmm = NULL; > > } > > -#else /* IS_ENABLED(CONFIG_HMM_MIRROR) */ > > +#endif > > + > > +#else /* IS_ENABLED(CONFIG_HMM) */ > > static inline void hmm_mm_destroy(struct mm_struct *mm) {} > > static inline void hmm_mm_init(struct mm_struct *mm) {} > > -#endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */ > > - > > - > > #endif /* IS_ENABLED(CONFIG_HMM) */ > > #endif /* LINUX_HMM_H */ > > What happens when CONFIG_HMM is defined but CONFIG_HMM_MIRROR is not? > Or is that not possible (in which case why would we have > CONFIG_HMM_MIRROR)? This is something to Jerome to answer but hmm_mm_init/hmm_mm_destroy are used regardless of the specific HMM configuration so an empty stub should be defined unconditionally AFAIU. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org