All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: "Lan, Tianyu" <tianyu.lan@intel.com>
Cc: kevin.tian@intel.com, "Wei Liu" <wei.liu2@citrix.com>,
	andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
	xen-devel@lists.xen.org, jbeulich@suse.com, chao.gao@intel.com,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [RFC PATCH 2/5] XL: Increase event channels to support more vcpus
Date: Mon, 28 Aug 2017 10:21:15 +0100	[thread overview]
Message-ID: <20170828092115.i4be6bf5pot6jkrc@citrix.com> (raw)
In-Reply-To: <65152b90-999b-5567-f979-ae14ff589fb8@intel.com>

On Mon, Aug 28, 2017 at 05:11:27PM +0800, Lan, Tianyu wrote:
> On 8/25/2017 6:04 PM, Wei Liu wrote:
> > On Fri, Aug 25, 2017 at 10:57:26AM +0100, Roger Pau Monné wrote:
> > > On Fri, Aug 25, 2017 at 10:18:24AM +0100, Wei Liu wrote:
> > > > On Thu, Aug 24, 2017 at 10:52:17PM -0400, Lan Tianyu wrote:
> > > > > This patch is to increase event channels to support more vcpus in single VM.
> > > > > 
> > > > > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> > > > 
> > > > There is no need to bump the default. There is already a configuration
> > > > option called max_event_channel.
> > > 
> > > Maybe make this somehow based on the number of vCPUs assigned to the
> > > domain?
> > > 
> > > It's not very used-friendly to allow the creation of a domain with 256
> > > vCPUs for example that would then get stuck during boot.
> > > 
> > > Or at least check max_event_channel and the number of vCPUs and print
> > > a warning message to alert the user that things might go wrong with
> > > this configuration.
> > > 
> > 
> > The problem is number of vcpu is only one factor that would affect the
> > number of event channels needed.
> 
> How about producing a warning about event channel maybe not enough when vcpu
> number is >128 and still uses default max event channel number?
> 

Maybe. If you're going to do that, please:

1. provide the heuristic in a function so that it can be expand later.
2. make the message system administrator friendly, point them to the
   max_event_channels option.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-08-28  9:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  2:52 [RFC PATCH 0/5] Extend resources to support more vcpus in single VM Lan Tianyu
2017-08-25  2:52 ` [RFC PATCH 1/5] xen/hap: Increase hap size for more vcpus support Lan Tianyu
2017-08-25  9:14   ` Wei Liu
2017-08-28  8:53     ` Lan, Tianyu
2017-08-25  2:52 ` [RFC PATCH 2/5] XL: Increase event channels to support more vcpus Lan Tianyu
2017-08-25  9:18   ` Wei Liu
2017-08-25  9:57     ` Roger Pau Monné
2017-08-25 10:04       ` Wei Liu
2017-08-28  9:11         ` Lan, Tianyu
2017-08-28  9:21           ` Wei Liu [this message]
2017-08-28  9:22           ` Jan Beulich
2017-08-25  2:52 ` [RFC PATCH 3/5] Tool/ACPI: DSDT extension " Lan Tianyu
2017-08-25  9:25   ` Wei Liu
2017-08-28  9:12     ` Lan, Tianyu
2017-08-25 10:36   ` Roger Pau Monné
2017-08-25 12:01     ` Jan Beulich
2017-08-29  4:58       ` Lan Tianyu
2017-08-29  5:01     ` Lan Tianyu
2017-08-25  2:52 ` [RFC PATCH 4/5] hvmload: Add x2apic entry support in the MADT build Lan Tianyu
2017-08-25  9:26   ` Wei Liu
2017-08-25  9:43     ` Jan Beulich
2017-08-25 10:11   ` Roger Pau Monné
2017-08-29  3:14     ` Lan Tianyu
2017-08-25  2:52 ` [RFC PATCH 5/5] xl/libacpi: extend lapic_id() to uint32_t Lan Tianyu
2017-08-25  9:22   ` Wei Liu
2017-08-25 14:10 ` [RFC PATCH 0/5] Extend resources to support more vcpus in single VM Meng Xu
2017-08-29  4:38   ` Lan Tianyu
2017-08-29  8:49     ` Jan Beulich
2017-08-30  5:33       ` Lan Tianyu
2017-08-30  7:12         ` Jan Beulich
2017-08-30  9:18           ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828092115.i4be6bf5pot6jkrc@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chao.gao@intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=tianyu.lan@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.