All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib/kmod: Fix error reporting for kmod load/unload
Date: Mon, 28 Aug 2017 12:36:15 +0300	[thread overview]
Message-ID: <20170828093615.vi6st3cf7w76lstn@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20170825172836.22094-1-chris@chris-wilson.co.uk>

On Fri, Aug 25, 2017 at 06:28:36PM +0100, Chris Wilson wrote:
> A "return -err ? err < 0 : err" managed to slip through. So if err was
> set, we returned 0 or 1 based on sign, or 0 if err was zero.
> 
> If err is negative, we want treat it as an error, so report it back
> to the caller, all other values were a success, so convert those to 0.
> 
> This should actually be no functional change, as all errors were
> reported as 1, and everything else as 0.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2017-08-28  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 17:28 [PATCH igt] lib/kmod: Fix error reporting for kmod load/unload Chris Wilson
2017-08-25 17:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-26  0:54 ` ✓ Fi.CI.IGT: " Patchwork
2017-08-28  9:36 ` Petri Latvala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828093615.vi6st3cf7w76lstn@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.