From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbdH3Hre (ORCPT ); Wed, 30 Aug 2017 03:47:34 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:37310 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdH3Hrc (ORCPT ); Wed, 30 Aug 2017 03:47:32 -0400 Date: Wed, 30 Aug 2017 09:47:38 +0200 From: Johan Hovold To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Johan Hovold , "Maciej S . Szmigiero" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: simplify 3 D-Link device entries Message-ID: <20170830074738.GM20634@localhost> References: <20170829082717.GH20634@localhost> <20170829084513.15953-1-bjorn@mork.no> <20170829144121.GJ20634@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170829144121.GJ20634@localhost> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 04:41:21PM +0200, Johan Hovold wrote: > On Tue, Aug 29, 2017 at 10:45:13AM +0200, Bjørn Mork wrote: > > All the vendor specific interfaces on these devices are serial > > functions handled by this driver, so we can use a single class > > match entry for each. > > > > P: Vendor=2001 ProdID=7d01 Rev= 3.00 > > S: Manufacturer=D-Link,Inc > > S: Product=D-Link DWM-156 > > C:* #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA > > A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > > I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > > E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=125us > > I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > > I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=02 Prot=01 Driver=option > > E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=500us > > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > I:* If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > I:* If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > I:* If#= 6 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage > > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > > > Signed-off-by: Bjørn Mork > > --- > > > > Johan Hovold writes: > > > > > Do you want to submit a patch or should I do it? > > > > Well, I can save you that job if this is fine with you. Feel > > free to add a stable cc if you think it is appropriate. I am not > > sure... > > Thanks! Yeah, not sure about stable either. Maybe I'll just apply this > one on top the new entry coming in, and we can defer the decision to the > stable maintainers next time there's a backport conflict. Now applied (without stable-CC). Thanks, Johan