From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/mm: Rearrange guest_get_eff_{, kern_}l1e() not be void
Date: Wed, 30 Aug 2017 14:29:03 +0100 [thread overview]
Message-ID: <20170830132903.jsrd2a4ybqwud3rt@citrix.com> (raw)
In-Reply-To: <1504099325-31132-1-git-send-email-andrew.cooper3@citrix.com>
On Wed, Aug 30, 2017 at 02:22:05PM +0100, Andrew Cooper wrote:
> Coverity complains that gl1e.l1 may be used while uninitialised in
> map_ldt_shadow_page(). This isn't actually accurate as guest_get_eff_l1e()
> will always write to its parameter.
>
> However, having a void function which returns a 64bit value via pointer is
> rather silly. Rearrange the functions to return l1_pgentry_t.
>
> No functional change, but hopefully should help Coverity not to come to the
> wrong conclusion.
>
> Bloat-o-meter also reports a modest improvement:
> add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-71 (-71)
> function old new delta
> guest_get_eff_l1e 82 75 -7
> mmio_ro_do_page_fault 530 514 -16
> map_ldt_shadow_page 501 485 -16
> ptwr_do_page_fault 615 583 -32
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-30 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:22 [PATCH] x86/mm: Rearrange guest_get_eff_{, kern_}l1e() not be void Andrew Cooper
2017-08-30 13:29 ` Wei Liu [this message]
2017-08-30 15:51 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830132903.jsrd2a4ybqwud3rt@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.