From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay
Date: Wed, 30 Aug 2017 09:24:02 -0700 [thread overview]
Message-ID: <20170830162402.GP4757@magnolia> (raw)
In-Reply-To: <8f1f6b47-988f-6cba-181d-d0be01fa3aa2@redhat.com>
On Wed, Aug 30, 2017 at 10:53:22AM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 1b625d0..79cb5b3 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -520,7 +520,6 @@
> struct inode *inode,
> loff_t offset,
> loff_t count,
> - unsigned flags,
> struct iomap *iomap)
> {
> struct xfs_inode *ip = XFS_I(inode);
> @@ -984,8 +983,7 @@ static inline bool need_excl_ilock(struct xfs_inode *ip, unsigned flags)
> if (((flags & (IOMAP_WRITE | IOMAP_DIRECT)) == IOMAP_WRITE) &&
> !IS_DAX(inode) && !xfs_get_extsz_hint(ip)) {
> /* Reserve delalloc blocks for regular writeback. */
> - return xfs_file_iomap_begin_delay(inode, offset, length, flags,
> - iomap);
> + return xfs_file_iomap_begin_delay(inode, offset, length, iomap);
> }
>
> if (need_excl_ilock(ip, flags)) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-30 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 15:53 [PATCH] xfs: remove unused flags arg from xfs_file_iomap_begin_delay Eric Sandeen
2017-08-30 16:24 ` Darrick J. Wong [this message]
2017-08-31 13:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830162402.GP4757@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.